javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 14:01:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(modal): backdrop click catches navigation promise

Browse Source 
A modal with canLeave = false, can lead to an unhandled exception when closing through a click in the backdrop
This commit is contained in:
Manu Mtz.-Almeida
2016-11-19 18:15:26 +01:00
parent 053c7546d4
commit e46d8d6938
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/modal/modal-component.ts
View File

@ -75,7 +75,9 @@ export class ModalCmp {
_bdClick() { _bdClick() {
if (this._enabled && this._bdDismiss) { if (this._enabled && this._bdDismiss) {
return this._viewCtrl.dismiss(null, 'backdrop'); return this._viewCtrl.dismiss(null, 'backdrop').catch(() => {
console.debug('Dismiss modal by clicking backdrop was cancelled');
});
} }
} }