javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 15:51:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(many): add tech debt tickets and remove unnecessary todos (#26266)

Browse Source
This commit is contained in:
Amanda Johnston
2022-11-14 14:49:08 -06:00
committed by GitHub
parent 5a701b5b42
commit e3ef932ae1
40 changed files with 17 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/components/nav/view-controller.ts
View File

@ -81,13 +81,6 @@ export const convertToViews = (pages: NavComponentWithProps[]): ViewController[]
return page;
}
if ('component' in page) {
/**
* TODO Ionic 6:
* Consider switching to just using `undefined` here
* as well as on the public interfaces and on
* `NavComponentWithProps`. Previously `pages` was
* of type `any[]` so TypeScript did not catch this.
*/
return convertToView(page.component, page.componentProps === null ? undefined : page.componentProps);
}
return convertToView(page, undefined);