From e3d7282b57ed5ae63b59c640e81a39c6e12d84f7 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Mon, 17 Dec 2018 17:27:03 -0500 Subject: [PATCH] fix(action-sheet): set 100% height to fix scrollable options (#16789) * test(action-sheet): include more buttons to scroll in the screenshot --- .../components/action-sheet/action-sheet.scss | 4 ++-- .../test/scrollable-options/index.html | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/core/src/components/action-sheet/action-sheet.scss b/core/src/components/action-sheet/action-sheet.scss index d310d03c10..61b384af9f 100644 --- a/core/src/components/action-sheet/action-sheet.scss +++ b/core/src/components/action-sheet/action-sheet.scss @@ -23,8 +23,8 @@ --width: #{$action-sheet-width}; --max-width: #{$action-sheet-max-width}; --min-height: auto; - --height: auto; - --max-height: auto; + --height: 100%; + --max-height: 100%; @include font-smoothing(); @include position(0, 0, 0, 0); diff --git a/core/src/components/action-sheet/test/scrollable-options/index.html b/core/src/components/action-sheet/test/scrollable-options/index.html index 48a61792c7..332c51a340 100644 --- a/core/src/components/action-sheet/test/scrollable-options/index.html +++ b/core/src/components/action-sheet/test/scrollable-options/index.html @@ -73,11 +73,21 @@ handler: () => { console.log('Mark Unread clicked'); } + }, { + text: 'Mark Read', + handler: () => { + console.log('Mark Read clicked'); + } }, { text: 'Edit Title', handler: () => { console.log('Edit Title clicked'); } + }, { + text: 'Erase Title', + handler: () => { + console.log('Erase Title clicked'); + } }, { text: 'Save Image', handler: () => { @@ -88,6 +98,12 @@ handler: () => { console.log('Copy Image clicked'); } + }, { + }, { + text: 'Erase Image', + handler: () => { + console.log('Erase Image clicked'); + } }, { text: 'Delete File', role: 'destructive',