javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 11:17:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(ios): account for nested tabs with page transition (#20955)

Browse Source 
fixes #20948
This commit is contained in:
Liam DeBeasi
2020-04-02 15:03:08 -04:00
committed by GitHub
parent e0f3c09bab
commit e23dec5eb9
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/utils/transition/ios.transition.ts
View File

@ -18,7 +18,7 @@ const getLargeTitle = (refEl: any) => {
if (tabs != null) {
const activeTab = tabs.querySelector('ion-tab:not(.tab-hidden), .ion-page:not(.ion-page-hidden)');
return activeTab.querySelector(query);
return (activeTab != null) ? activeTab.querySelector(query) : null;
}
return refEl.querySelector(query);
@ -30,7 +30,9 @@ const getBackButton = (refEl: any, backDirection: boolean) => {
if (tabs != null) {
const activeTab = tabs.querySelector('ion-tab:not(.tab-hidden), .ion-page:not(.ion-page-hidden)');
buttonsList = activeTab.querySelectorAll('ion-buttons');
if (activeTab != null) {
buttonsList = activeTab.querySelectorAll('ion-buttons');
}
} else {
buttonsList = refEl.querySelectorAll('ion-buttons');
}