javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 18:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): checking if node is actually an element before treating it like one, fixes #19769 (#19783)

Browse Source
This commit is contained in:
Ely Lucas
2019-10-29 10:36:28 -06:00
parent 1f2b161ccd
commit e23d91c6e7
1 changed files with 24 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/react/src/components/utils/attachProps.ts
View File

@ -1,6 +1,8 @@
import { camelToDashCase } from './case'; import { camelToDashCase } from './case';
export const attachProps = (node: HTMLElement, newProps: any, oldProps: any = {}) => { export const attachProps = (node: HTMLElement, newProps: any, oldProps: any = {}) => {
// some test frameworks don't render DOM elements, so we test here to make sure we are dealing with DOM first
if (node instanceof Element) {
// add any classes in className to the class list // add any classes in className to the class list
const className = getClassName(node.classList, newProps, oldProps); const className = getClassName(node.classList, newProps, oldProps);
if (className !== '') { if (className !== '') {
@ -28,6 +30,7 @@ export const attachProps = (node: HTMLElement, newProps: any, oldProps: any = {}
} }
} }
}); });
}
}; };
export const getClassName = (classList: DOMTokenList, newProps: any, oldProps: any) => { export const getClassName = (classList: DOMTokenList, newProps: any, oldProps: any) => {