Was scavaging around the other day and...
+ + + +I've placed information vital to the survival...
-I think I figured out how to get more Mountain Dew diff --git a/ionic/components/nav/nav-controller.ts b/ionic/components/nav/nav-controller.ts index bae12c2640..185cb06a8b 100644 --- a/ionic/components/nav/nav-controller.ts +++ b/ionic/components/nav/nav-controller.ts @@ -579,7 +579,7 @@ export class NavController extends Ion { _setZIndex(enteringInstance, leavingInstance, direction) { if (!leavingInstance) { - enteringInstance._zIndex = 0; + enteringInstance._zIndex = 10; } else if (direction === 'back') { // moving back diff --git a/ionic/components/nav/test/nav-controller.spec.ts b/ionic/components/nav/test/nav-controller.spec.ts index 84e5d546da..801fd1809d 100644 --- a/ionic/components/nav/test/nav-controller.spec.ts +++ b/ionic/components/nav/test/nav-controller.spec.ts @@ -1,20 +1,3 @@ -// import { -// ddescribe, -// describe, -// xdescribe, -// it, -// iit, -// xit, -// expect, -// beforeEach, -// afterEach, -// AsyncTestCompleter, -// inject, -// beforeEachBindings -// } from 'angular2/test'; - -// import {Compiler} from 'angular2/angular2'; - import { NavController, Config, diff --git a/ionic/components/tabs/modes/md.scss b/ionic/components/tabs/modes/md.scss index af0a777f44..25ebc48d99 100644 --- a/ionic/components/tabs/modes/md.scss +++ b/ionic/components/tabs/modes/md.scss @@ -65,3 +65,6 @@ tab-highlight { } } +[tab-bar-placement=bottom] tab-highlight { + top: 0; +} diff --git a/ionic/components/tap-click/ripple.scss b/ionic/components/tap-click/ripple.scss index 2b6f7f33a4..0399e6d2d1 100644 --- a/ionic/components/tap-click/ripple.scss +++ b/ionic/components/tap-click/ripple.scss @@ -18,3 +18,7 @@ md-ripple { transform: scale(0.001) translateZ(0); } + +ion-item-sliding md-ripple { + z-index: 2; +} diff --git a/ionic/components/tap-click/tap-click.ts b/ionic/components/tap-click/tap-click.ts index 861f5a2c27..940d525658 100644 --- a/ionic/components/tap-click/tap-click.ts +++ b/ionic/components/tap-click/tap-click.ts @@ -174,14 +174,14 @@ function getActivatableTarget(ele) { return null; } -function isActivatable(ele) { - if (/^(A|BUTTON)$/.test(ele.tagName)) { +export function isActivatable(ele) { + if (ACTIVATABLE_ELEMENTS.test(ele.tagName)) { return true; } let attributes = ele.attributes; for (let i = 0, l = attributes.length; i < l; i++) { - if (/click|tappable/.test(attributes[i].name)) { + if (ACTIVATABLE_ATTRIBUTES.test(attributes[i].name)) { return true; } } @@ -200,3 +200,6 @@ function addListener(type, listener, useCapture) { function removeListener(type, listener) { doc.removeEventListener(type, listener); } + +const ACTIVATABLE_ELEMENTS = /^(A|BUTTON)$/; +const ACTIVATABLE_ATTRIBUTES = /tappable/; diff --git a/ionic/components/tap-click/test/tapClick.spec.ts b/ionic/components/tap-click/test/tapClick.spec.ts new file mode 100644 index 0000000000..ba51b24fde --- /dev/null +++ b/ionic/components/tap-click/test/tapClick.spec.ts @@ -0,0 +1,44 @@ +import * as tapClick from 'ionic/ionic'; + +export function run() { + + describe("TapClick", () => { + + describe("isActivatable", () => { + + it('should be activatable on element', () => { + let ele = document.createElement('a'); + expect( tapClick.isActivatable(ele) ).toBe(true); + }); + + it('should be activatable on