From df84d155ea92178ec32ed977fe0315f5b14f79e9 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 4 Feb 2022 11:27:16 -0500 Subject: [PATCH] ci(e2e): do not run sync automatically (#24717) --- .github/workflows/actions/test-angular-e2e/action.yml | 4 ++++ angular/test/test-app/package.json | 6 +++--- packages/react-router/test-app/package.json | 2 +- packages/react/test-app/package.json | 2 +- packages/vue/test-app/package.json | 2 +- 5 files changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/actions/test-angular-e2e/action.yml b/.github/workflows/actions/test-angular-e2e/action.yml index dd4d12dbe7..43d9438625 100644 --- a/.github/workflows/actions/test-angular-e2e/action.yml +++ b/.github/workflows/actions/test-angular-e2e/action.yml @@ -33,6 +33,10 @@ runs: run: npm install shell: bash working-directory: ./angular/test/test-app + - name: Sync Built Changes + run: npm run sync + shell: bash + working-directory: ./angular/test/test-app - name: Run Tests run: npm run test shell: bash diff --git a/angular/test/test-app/package.json b/angular/test/test-app/package.json index 1e7ce1791a..2404b0442c 100644 --- a/angular/test/test-app/package.json +++ b/angular/test/test-app/package.json @@ -4,12 +4,12 @@ "private": true, "scripts": { "ng": "ng", - "start": "npm run sync && ng serve", + "start": "ng serve", "sync:build": "sh scripts/build-ionic.sh", "sync": "sh scripts/sync.sh", - "build": "npm run sync && ng build --configuration production --no-progress", + "build": "ng build --configuration production --no-progress", "lint": "ng lint", - "postinstall": "npm run sync && ngcc", + "postinstall": "ngcc", "serve:ssr": "node dist/test-app/server/main.js", "build:ssr": "ng build --prod && ng run test-app:server:production", "dev:ssr": "ng run test-app:serve-ssr", diff --git a/packages/react-router/test-app/package.json b/packages/react-router/test-app/package.json index 2659bde5b5..fb6925569f 100644 --- a/packages/react-router/test-app/package.json +++ b/packages/react-router/test-app/package.json @@ -35,7 +35,7 @@ "wait-on": "^5.3.0" }, "scripts": { - "start": "npm run sync && react-scripts start", + "start": "react-scripts start", "start.ci": "npm run sync && BROWSER=none react-scripts start", "build": "node scripts/build.js", "test": "cypress open", diff --git a/packages/react/test-app/package.json b/packages/react/test-app/package.json index 0cb7b1c4f9..79510abea0 100644 --- a/packages/react/test-app/package.json +++ b/packages/react/test-app/package.json @@ -42,7 +42,7 @@ "workbox-streams": "^5.1.4" }, "scripts": { - "start": "npm run sync && react-scripts start", + "start": "react-scripts start", "start.ci": "npm run sync && BROWSER=none react-scripts start", "build": "react-scripts build", "test": "react-scripts test", diff --git a/packages/vue/test-app/package.json b/packages/vue/test-app/package.json index 9cba57f112..3fe2b0628a 100644 --- a/packages/vue/test-app/package.json +++ b/packages/vue/test-app/package.json @@ -9,7 +9,7 @@ "test:e2e": "concurrently \"npm run start\" \"wait-on http-get://localhost:8080 && npm run cypress\" --kill-others --success first", "lint": "vue-cli-service lint", "cypress": "node_modules/.bin/cypress run --headless --browser chrome", - "start": "npm run sync && vue-cli-service serve", + "start": "vue-cli-service serve", "sync": "sh ./scripts/sync.sh" }, "dependencies": {