javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-24 14:58:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix(): check if values are undef before passing down to input."

Browse Source 
This reverts commit 8b7038fde79bb9267ab7c296150f7839ee8cc9b4.
This commit is contained in:
Josh Thomas
2017-10-19 09:56:53 -05:00
parent 8b7038fde7
commit df80971eb0
1 changed files with 25 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
packages/core/src/components/input/input.tsx
View File

@ -318,14 +318,6 @@ export class Input implements InputComponent {
return (this.value !== null && this.value !== undefined && this.value !== ''); return (this.value !== null && this.value !== undefined && this.value !== '');
} }
reduceUndefProps(props: { [ key: string]: any}) {
return Object.keys(props).reduce((final, propName) => {
if (props[propName] != null) {
final[propName] = props[propName];
}
return final;
}, {} as { [key: string]: any});
}
protected render() { protected render() {
const themedClasses = createThemedClasses(this.mode, this.color, 'text-input'); const themedClasses = createThemedClasses(this.mode, this.color, 'text-input');
@ -334,37 +326,35 @@ export class Input implements InputComponent {
return [ return [
<input <input
aria-disabled={this.disabled ? 'true' : false} aria-disabled={this.disabled ? 'true' : false}
accept={this.accept}
autoCapitalize={this.autocapitalize}
autoComplete={this.autocomplete}
autoCorrect={this.autocorrect}
autoFocus={this.autofocus}
checked={this.checked}
disabled={this.disabled}
inputMode={this.inputmode}
min={this.min}
max={this.max}
minLength={this.minlength}
maxLength={this.maxlength}
multiple={this.multiple}
name={this.name}
pattern={this.pattern}
placeholder={this.placeholder}
results={this.results}
readOnly={this.readonly}
required={this.required}
spellCheck={this.spellcheck}
step={this.step}
size={this.size}
type={this.type}
value={this.value}
class={themedClasses}
onBlur={this.inputBlurred.bind(this)} onBlur={this.inputBlurred.bind(this)}
onInput={this.inputChanged.bind(this)} onInput={this.inputChanged.bind(this)}
onFocus={this.inputFocused.bind(this)} onFocus={this.inputFocused.bind(this)}
onKeyDown={this.inputKeydown.bind(this)} onKeyDown={this.inputKeydown.bind(this)}
{...this.reduceUndefProps({
accept: this.accept,
autoCapitalize: this.autocapitalize,
autoComplete: this.autocomplete,
autoCorrect: this.autocorrect,
autoFocus: this.autofocus,
checked: this.checked,
disabled: this.disabled,
inputMode: this.inputmode,
min: this.min,
max: this.max,
minLength: this.minlength,
maxLength: this.maxlength,
multiple: this.multiple,
name: this.name,
pattern: this.pattern,
placeholder: this.placeholder,
results: this.results,
readOnly: this.readonly,
required: this.required,
spellCheck: this.spellcheck,
step: this.step,
size: this.size,
type: this.type,
value: this.value,
class: themedClasses
})}
/>, />,
<button <button
hidden={this.clearInput !== true} hidden={this.clearInput !== true}