From 45647c4f4961eb7c1681733aacff30ed22ddb997 Mon Sep 17 00:00:00 2001 From: Ralf Stich Date: Wed, 16 Mar 2016 10:14:48 +0100 Subject: [PATCH 1/8] lacks return-type annotation, implicitly has an 'any' return type Fix for tsc with 'noImplicitAny' option --- ionic/components/slides/swiper-widget.d.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ionic/components/slides/swiper-widget.d.ts b/ionic/components/slides/swiper-widget.d.ts index af8c8bb351..97750f3fb2 100644 --- a/ionic/components/slides/swiper-widget.d.ts +++ b/ionic/components/slides/swiper-widget.d.ts @@ -4,9 +4,9 @@ export declare class Swiper { activeIndex: number; isEnd: boolean; isBeginning: boolean; - - update(); - slideNext(); - slidePrev(); - -} \ No newline at end of file + + update():any; + slideNext():any; + slidePrev():any; + +} From b8cb12e25eef3483a09db140ab955502df74ae52 Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Thu, 31 Mar 2016 08:58:08 -0500 Subject: [PATCH 2/8] chore(): remove console.debugs --- ionic/components/infinite-scroll/infinite-scroll.ts | 1 - ionic/components/refresher/refresher.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/ionic/components/infinite-scroll/infinite-scroll.ts b/ionic/components/infinite-scroll/infinite-scroll.ts index 46e2fed086..458322e52c 100644 --- a/ionic/components/infinite-scroll/infinite-scroll.ts +++ b/ionic/components/infinite-scroll/infinite-scroll.ts @@ -178,7 +178,6 @@ export class InfiniteScroll { let distanceFromInfinite = ((d.scrollHeight - infiniteHeight) - d.scrollTop) - reloadY; if (distanceFromInfinite < 0) { this._zone.run(() => { - console.debug('infinite scroll'); this.state = STATE_LOADING; this.infinite.emit(this); }); diff --git a/ionic/components/refresher/refresher.ts b/ionic/components/refresher/refresher.ts index 881dbfcb4f..b197006c25 100644 --- a/ionic/components/refresher/refresher.ts +++ b/ionic/components/refresher/refresher.ts @@ -251,7 +251,6 @@ export class Refresher { // this method can get called like a bazillion times per second, // so it's built to be as efficient as possible, and does its // best to do any DOM read/writes only when absolutely necessary - console.debug('Pull-to-refresh, onMove', ev.type); // if multitouch then get out immediately if (ev.touches && ev.touches.length > 1) { From 55fb60e09b17b7670bf18a6972a3d0f4ad08b0f1 Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Thu, 31 Mar 2016 09:23:28 -0500 Subject: [PATCH 3/8] docs(): fix typo --- ionic/components/toolbar/toolbar.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ionic/components/toolbar/toolbar.ts b/ionic/components/toolbar/toolbar.ts index 6de072e823..d9515f3a7e 100644 --- a/ionic/components/toolbar/toolbar.ts +++ b/ionic/components/toolbar/toolbar.ts @@ -92,7 +92,8 @@ export class ToolbarBase extends Ion { * * ``` * - * @property {any} [position] - set position of the toolbar, top or bottom. If not set, defautls to top. + * @property {any} [position] - set position of the toolbar, `top` or `bottom`. + * Default `top`. * @demo /docs/v2/demos/toolbar/ * @see {@link ../../navbar/Navbar/ Navbar API Docs} */ From 3df1ad5192eac19314a50c4c73e2f947b6eddddf Mon Sep 17 00:00:00 2001 From: Tim Lancina Date: Thu, 31 Mar 2016 16:00:43 -0500 Subject: [PATCH 4/8] chore(): move nested functions out of if blocks --- ionic/util/dom.ts | 47 ++++++++++++++++++++++++----------------------- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/ionic/util/dom.ts b/ionic/util/dom.ts index 93f4a2cf4c..4d0dd3540e 100644 --- a/ionic/util/dom.ts +++ b/ionic/util/dom.ts @@ -91,25 +91,25 @@ export let CSS: { export function transitionEnd(el: HTMLElement, callback: Function) { if (el) { - function unregister() { - CSS.transitionEnd.split(' ').forEach(eventName => { - el.removeEventListener(eventName, onEvent); - }); - } - - function onEvent(ev) { - if (el === ev.target) { - unregister(); - callback(ev); - } - } - CSS.transitionEnd.split(' ').forEach(eventName => { el.addEventListener(eventName, onEvent); }); return unregister; } + + function unregister() { + CSS.transitionEnd.split(' ').forEach(eventName => { + el.removeEventListener(eventName, onEvent); + }); + } + + function onEvent(ev) { + if (el === ev.target) { + unregister(); + callback(ev); + } + } } export function ready(callback?: Function) { @@ -124,17 +124,17 @@ export function ready(callback?: Function) { callback(); } else { - function completed() { - document.removeEventListener('DOMContentLoaded', completed, false); - window.removeEventListener('load', completed, false); - callback(); - } - document.addEventListener('DOMContentLoaded', completed, false); window.addEventListener('load', completed, false); } return promise; + + function completed() { + document.removeEventListener('DOMContentLoaded', completed, false); + window.removeEventListener('load', completed, false); + callback(); + } } export function windowLoad(callback?: Function) { @@ -149,15 +149,16 @@ export function windowLoad(callback?: Function) { callback(); } else { - function completed() { - window.removeEventListener('load', completed, false); - callback(); - } window.addEventListener('load', completed, false); } return promise; + + function completed() { + window.removeEventListener('load', completed, false); + callback(); + } } export function pointerCoord(ev: any): {x: number, y: number} { From b832b4c502bbd01250f4e7a5017a153d6449ab03 Mon Sep 17 00:00:00 2001 From: perry Date: Fri, 1 Apr 2016 11:57:27 -0500 Subject: [PATCH 5/8] docs(dgeni): fix doc update link --- scripts/docs/processors/jekyll.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/docs/processors/jekyll.js b/scripts/docs/processors/jekyll.js index 1d3a68fd4e..0c381e304b 100644 --- a/scripts/docs/processors/jekyll.js +++ b/scripts/docs/processors/jekyll.js @@ -21,6 +21,8 @@ module.exports = function jekyll(renderDocsProcessor) { .replace('/index.md','') .replace('//home/ubuntu/ionic/ionic', '') .replace('//', '/'); + docs[i].relativePath = doc.relativePath + .replace('//home/ubuntu/ionic', ''); }); docs.push({ From ff17cf836cf9813872aaacb12ef9188bd4c1ebfe Mon Sep 17 00:00:00 2001 From: perry Date: Fri, 1 Apr 2016 12:30:52 -0500 Subject: [PATCH 6/8] chore(dgeni): some docs don't have a relativePath --- scripts/docs/processors/jekyll.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/docs/processors/jekyll.js b/scripts/docs/processors/jekyll.js index 0c381e304b..a429c38701 100644 --- a/scripts/docs/processors/jekyll.js +++ b/scripts/docs/processors/jekyll.js @@ -21,8 +21,10 @@ module.exports = function jekyll(renderDocsProcessor) { .replace('/index.md','') .replace('//home/ubuntu/ionic/ionic', '') .replace('//', '/'); - docs[i].relativePath = doc.relativePath - .replace('//home/ubuntu/ionic', ''); + if (docs[i].relativePath) { + docs[i].relativePath = doc.relativePath + .replace('//home/ubuntu/ionic', ''); + } }); docs.push({ From 50d2d0875be3ad205861c4b7e93a190ccb1ddeb7 Mon Sep 17 00:00:00 2001 From: perry Date: Fri, 1 Apr 2016 13:07:18 -0500 Subject: [PATCH 7/8] chore(dgeni): TS 1.8 dgeni tweak and CI perf improvements --- scripts/docs/deploy.sh | 6 +++--- scripts/docs/templates/common.template.html | 2 +- scripts/git/clone.sh | 2 ++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/scripts/docs/deploy.sh b/scripts/docs/deploy.sh index 8c20ea7492..f3ef689d28 100755 --- a/scripts/docs/deploy.sh +++ b/scripts/docs/deploy.sh @@ -39,11 +39,11 @@ function run { # if no changes, don't commit if [[ "$CHANGES" == "" ]]; then - ls - echo "-- No changes detected in docs for $VERSION_NAME; docs not updated." + echo "-- No changes detected for the following commit, docs not updated." + echo "https://github.com/driftyco/$CIRCLE_PROJECT_REPONAME/commit/$CIRCLE_SHA1" else git add -A - git commit -am "docs: update for $VERSION" + git commit -am "Automated build of ionic v$VERSION driftyco/$CIRCLE_PROJECT_REPONAME@$CIRCLE_SHA1" git push origin master echo "-- Updated docs for $VERSION_NAME succesfully!" diff --git a/scripts/docs/templates/common.template.html b/scripts/docs/templates/common.template.html index c20a4f29d1..c8bef302cf 100644 --- a/scripts/docs/templates/common.template.html +++ b/scripts/docs/templates/common.template.html @@ -147,7 +147,7 @@ Delegate: <$ doc.delegate $> - + Improve this doc diff --git a/scripts/git/clone.sh b/scripts/git/clone.sh index 07a064575b..2eb173ebe7 100755 --- a/scripts/git/clone.sh +++ b/scripts/git/clone.sh @@ -16,6 +16,8 @@ function run { ARGS="--branch=${BRANCH:-master}" if [[ "$DEPTH" != "" ]]; then ARGS="$ARGS --depth=$DEPTH" + else + ARGS="$ARGS --depth=2" fi git clone https://driftyco:$GH_TOKEN@github.com/$REPOSITORY $DIRECTORY $ARGS cd $DIRECTORY From 9613881236e7b579cca44784dd41002f9c9d28f0 Mon Sep 17 00:00:00 2001 From: perry Date: Fri, 1 Apr 2016 13:18:08 -0500 Subject: [PATCH 8/8] chore(dgeni): debugging fix this doc link rel to TS 1.8 path bug --- scripts/docs/processors/jekyll.js | 2 +- scripts/docs/templates/common.template.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/docs/processors/jekyll.js b/scripts/docs/processors/jekyll.js index a429c38701..7d4ca2517b 100644 --- a/scripts/docs/processors/jekyll.js +++ b/scripts/docs/processors/jekyll.js @@ -23,7 +23,7 @@ module.exports = function jekyll(renderDocsProcessor) { .replace('//', '/'); if (docs[i].relativePath) { docs[i].relativePath = doc.relativePath - .replace('//home/ubuntu/ionic', ''); + .replace('/home/ubuntu/ionic', ''); } }); diff --git a/scripts/docs/templates/common.template.html b/scripts/docs/templates/common.template.html index c8bef302cf..6b9d4b269b 100644 --- a/scripts/docs/templates/common.template.html +++ b/scripts/docs/templates/common.template.html @@ -147,7 +147,7 @@ Delegate: <$ doc.delegate $> - + Improve this doc