diff --git a/core/src/components/loading/test/basic/loading.e2e.ts b/core/src/components/loading/test/basic/loading.e2e.ts index 96f02fc2b1..002ab53b45 100644 --- a/core/src/components/loading/test/basic/loading.e2e.ts +++ b/core/src/components/loading/test/basic/loading.e2e.ts @@ -1,70 +1,69 @@ import { expect } from '@playwright/test'; -import type { E2EPage } from '@utils/test/playwright'; +import type { E2EPage, ScreenshotFn } from '@utils/test/playwright'; import { configs, test } from '@utils/test/playwright'; +const runVisualTest = async (page: E2EPage, selector: string, screenshot: ScreenshotFn, screenshotModifier: string) => { + const ionLoadingDidPresent = await page.spyOnEvent('ionLoadingDidPresent'); + + await page.click(selector); + + await ionLoadingDidPresent.next(); + + await expect(page).toHaveScreenshot(screenshot(`loading-${screenshotModifier}-diff`)); +}; + configs().forEach(({ title, screenshot, config }) => { test.describe(title('loading: basic'), () => { - test.beforeEach(async ({ page }) => { + test('should open a basic loader', async ({ page }) => { await page.goto('/src/components/loading/test/basic', config); - }); - test.describe('loading: visual regression tests', () => { - const runVisualTest = async (page: E2EPage, selector: string, screenshotModifier: string) => { - const ionLoadingDidPresent = await page.spyOnEvent('ionLoadingDidPresent'); - const ionLoadingDidDismiss = await page.spyOnEvent('ionLoadingDidPresent'); + const loading = page.locator('ion-loading'); + const ionLoadingDidDismiss = await page.spyOnEvent('ionLoadingDidPresent'); - await page.click(selector); + await runVisualTest(page, '#basic-loading', screenshot, 'basic'); - await ionLoadingDidPresent.next(); + await loading.evaluate((el: HTMLIonLoadingElement) => el.dismiss()); - await expect(page).toHaveScreenshot(screenshot(`loading-${screenshotModifier}-diff`)); + await ionLoadingDidDismiss.next(); - const loading = page.locator('ion-loading'); - await loading.evaluate((el: HTMLIonLoadingElement) => el.dismiss()); - - await ionLoadingDidDismiss.next(); - - await expect(loading).toBeHidden(); - }; - test('should open a basic loader', async ({ page }) => { - await runVisualTest(page, '#basic-loading', 'basic'); - }); - test('should open a loader with long text', async ({ page }) => { - await runVisualTest(page, '#long-content-loading', 'long-content'); - }); - test('should open a loader with no spinner', async ({ page }) => { - await runVisualTest(page, '#no-spinner-loading', 'no-spinner'); - }); - test('should open a translucent loader', async ({ page }) => { - await runVisualTest(page, '#translucent-loading', 'translucent'); - }); - test('should open a loader with a custom class', async ({ page }) => { - await runVisualTest(page, '#custom-class-loading', 'custom-class'); - }); - test('should open a loader with html content', async ({ page }) => { - await runVisualTest(page, '#html-content-loading', 'html-content'); - }); + await expect(loading).toBeHidden(); }); }); }); /** - * These behaviors do not vary across modes/directions + * These behaviors do not vary across directions. */ -configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { - test.describe(title('loading: html attributes'), () => { - test('it should pass html attributes to the loader', async ({ page }) => { +configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { + test.describe(title('loading: variants rendering'), () => { + test.beforeEach(async ({ page }) => { await page.goto('/src/components/loading/test/basic', config); - - const ionLoadingDidPresent = await page.spyOnEvent('ionLoadingDidPresent'); - - await page.click('#basic-loading'); - - await ionLoadingDidPresent.next(); - - const loading = page.locator('ion-loading'); - await expect(loading).toHaveAttribute('data-testid', 'basic-loading'); + }); + test('should open a loader with long text', async ({ page }) => { + await runVisualTest(page, '#long-content-loading', screenshot, 'long-content'); + }); + test('should open a loader with no spinner', async ({ page }) => { + await runVisualTest(page, '#no-spinner-loading', screenshot, 'no-spinner'); + }); + test('should open a loader with a custom class', async ({ page }) => { + await runVisualTest(page, '#custom-class-loading', screenshot, 'custom-class'); }); }); +}); + +configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { + /** + * Translucency is only available on iOS. + */ + test.describe(title('loading: translucent rendering'), () => { + test('should open a translucent loader', async ({ page }) => { + await page.goto('/src/components/loading/test/basic', config); + await runVisualTest(page, '#translucent-loading', screenshot, 'translucent'); + }); + }); + + /** + * These behaviors do not vary across modes/directions + */ test.describe(title('loading: focus trapping'), () => { test('it should trap focus in the loader', async ({ page, browserName }) => { await page.goto('/src/components/loading/test/basic', config); diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 2e866a24d1..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 391c4bc04d..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index ef4a40f174..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 862cc0f071..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 29040f5741..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 9efae8d7f9..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 8d160bb10a..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 101e08e69c..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index aa04d3272d..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 8d95d1f18e..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 37677358d9..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index c1c0d64de3..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 743fe7d397..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index cb569bcd36..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index d010c6fd4b..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index ff53f176e3..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 93f8df1359..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 2e18e022ab..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 751a3219d0..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 58ca1a223b..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 60160ff78d..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 167844fce4..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index cafc4961f8..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 53887a22d5..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index d1f5aa4ceb..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 4dc9175693..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 8efb9f5a63..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index a02b4ff04d..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 62ac92c923..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 21f9c0a768..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index d6b61047b7..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 4c68dcf027..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index e0f94f41a6..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 05c0824b84..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 94db69b664..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 4181da62a8..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 09e07bfc6f..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 1e99896b03..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 4873bef857..0000000000 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/basic/loading.spec.tsx b/core/src/components/loading/test/basic/loading.spec.tsx new file mode 100644 index 0000000000..768beffe22 --- /dev/null +++ b/core/src/components/loading/test/basic/loading.spec.tsx @@ -0,0 +1,17 @@ +import { h } from '@stencil/core'; +import { newSpecPage } from '@stencil/core/testing'; + +import { Loading } from '../../loading'; + +describe('loading: htmlAttributes inheritance', () => { + it('should correctly inherit attributes on host', async () => { + const page = await newSpecPage({ + components: [Loading], + template: () => , + }); + + const loading = page.body.querySelector('ion-loading'); + + await expect(loading.getAttribute('data-testid')).toBe('basic-loading'); + }); +}); diff --git a/core/src/components/loading/test/is-open/loading.e2e.ts b/core/src/components/loading/test/is-open/loading.e2e.ts index babc4d9bd4..9a3020b2d0 100644 --- a/core/src/components/loading/test/is-open/loading.e2e.ts +++ b/core/src/components/loading/test/is-open/loading.e2e.ts @@ -6,29 +6,19 @@ import { configs, test } from '@utils/test/playwright'; */ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { test.describe(title('loading: isOpen'), () => { - test.beforeEach(async ({ page }) => { + test('should open and close the loading indicator', async ({ page }) => { await page.goto('/src/components/loading/test/is-open', config); - }); - test('should open the loading indicator', async ({ page }) => { const ionLoadingDidPresent = await page.spyOnEvent('ionLoadingDidPresent'); + const ionLoadingDidDismiss = await page.spyOnEvent('ionLoadingDidDismiss'); const loading = page.locator('ion-loading'); await page.click('#default'); await ionLoadingDidPresent.next(); await expect(loading).toBeVisible(); - }); - test('should open the loading indicator then close after a timeout', async ({ page }) => { - const ionLoadingDidPresent = await page.spyOnEvent('ionLoadingDidPresent'); - const ionLoadingDidDismiss = await page.spyOnEvent('ionLoadingDidDismiss'); - const loading = page.locator('ion-loading'); - - await page.click('#timeout'); - - await ionLoadingDidPresent.next(); - await expect(loading).toBeVisible(); + await loading.evaluate((el: HTMLIonLoadingElement) => (el.isOpen = false)); await ionLoadingDidDismiss.next(); await expect(loading).toBeHidden(); diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts b/core/src/components/loading/test/standalone/loading.e2e.ts index 0f15cf6acd..993105ac29 100644 --- a/core/src/components/loading/test/standalone/loading.e2e.ts +++ b/core/src/components/loading/test/standalone/loading.e2e.ts @@ -1,26 +1,23 @@ import { expect } from '@playwright/test'; import { configs, test } from '@utils/test/playwright'; -configs().forEach(({ title, screenshot, config }) => { +configs().forEach(({ title, config }) => { test.describe(title('loading: standalone'), () => { - test.beforeEach(async ({ page }) => { - await page.goto('/src/components/loading/test/standalone', config); - }); test('should open a basic loader', async ({ page }) => { + await page.goto('/src/components/loading/test/standalone', config); + const ionLoadingDidPresent = await page.spyOnEvent('ionLoadingDidPresent'); const ionLoadingDidDismiss = await page.spyOnEvent('ionLoadingDidPresent'); + const loading = page.locator('ion-loading'); await page.click('#basic-loading'); await ionLoadingDidPresent.next(); + await expect(loading).toBeVisible(); - await expect(page).toHaveScreenshot(screenshot(`loading-standalone-diff`)); - - const loading = page.locator('ion-loading'); await loading.evaluate((el: HTMLIonLoadingElement) => el.dismiss()); await ionLoadingDidDismiss.next(); - await expect(loading).toBeHidden(); }); }); diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index dc08dabbf1..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index f1b1156a85..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 3f1cca73c0..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index e0fa97e6e8..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 572074c298..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 29eb21c4f4..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 3df6571fc6..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index f063ee2e20..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 8da3ea350f..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 2cc6e4b4ec..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 45051182da..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 9220899dad..0000000000 Binary files a/core/src/components/loading/test/standalone/loading.e2e.ts-snapshots/loading-standalone-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ