bug(breadcrumbs): color attribute shows on DOM for Vue (#27040)

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
This commit is contained in:
Maria Hutt
2023-03-30 09:57:02 -07:00
committed by GitHub
parent 7864a21ca3
commit dd419c0066
6 changed files with 71 additions and 2 deletions

View File

@ -199,7 +199,7 @@ ion-breadcrumb,part,native
ion-breadcrumb,part,separator ion-breadcrumb,part,separator
ion-breadcrumbs,shadow ion-breadcrumbs,shadow
ion-breadcrumbs,prop,color,"danger" | "dark" | "light" | "medium" | "primary" | "secondary" | "success" | "tertiary" | "warning" | string & Record<never, never> | undefined,undefined,false,false ion-breadcrumbs,prop,color,"danger" | "dark" | "light" | "medium" | "primary" | "secondary" | "success" | "tertiary" | "warning" | string & Record<never, never> | undefined,undefined,false,true
ion-breadcrumbs,prop,itemsAfterCollapse,number,1,false,false ion-breadcrumbs,prop,itemsAfterCollapse,number,1,false,false
ion-breadcrumbs,prop,itemsBeforeCollapse,number,1,false,false ion-breadcrumbs,prop,itemsBeforeCollapse,number,1,false,false
ion-breadcrumbs,prop,maxItems,number | undefined,undefined,false,false ion-breadcrumbs,prop,maxItems,number | undefined,undefined,false,false

View File

@ -30,7 +30,7 @@ export class Breadcrumbs implements ComponentInterface {
* Default options are: `"primary"`, `"secondary"`, `"tertiary"`, `"success"`, `"warning"`, `"danger"`, `"light"`, `"medium"`, and `"dark"`. * Default options are: `"primary"`, `"secondary"`, `"tertiary"`, `"success"`, `"warning"`, `"danger"`, `"light"`, `"medium"`, and `"dark"`.
* For more information on colors, see [theming](/docs/theming/basics). * For more information on colors, see [theming](/docs/theming/basics).
*/ */
@Prop() color?: Color; @Prop({ reflect: true }) color?: Color;
/** /**
* The maximum number of breadcrumbs to show before collapsing. * The maximum number of breadcrumbs to show before collapsing.

View File

@ -70,6 +70,10 @@ const routes: Array<RouteRecordRaw> = [
path: '/components', path: '/components',
component: () => import('@/views/Components.vue'), component: () => import('@/views/Components.vue'),
}, },
{
path: '/components/breadcrumbs',
component: () => import('@/views/Breadcrumbs.vue')
},
{ {
path: '/components/select', path: '/components/select',
component: () => import('@/views/Select.vue') component: () => import('@/views/Select.vue')

View File

@ -0,0 +1,53 @@
<template>
<ion-page>
<ion-header>
<ion-toolbar>
<ion-title>Breadcrumbs</ion-title>
</ion-toolbar>
</ion-header>
<ion-content>
<h1>Default</h1>
<ion-breadcrumbs id="default">
<ion-breadcrumb href="#"> Home </ion-breadcrumb>
<ion-breadcrumb href="#electronics"> Electronics </ion-breadcrumb>
<ion-breadcrumb href="#photography"> Photography </ion-breadcrumb>
<ion-breadcrumb href="#cameras"> Cameras </ion-breadcrumb>
<ion-breadcrumb href="#film"> Film </ion-breadcrumb>
<ion-breadcrumb> 35 mm </ion-breadcrumb>
</ion-breadcrumbs>
<hr />
<h1>Color: Danger</h1>
<ion-breadcrumbs id="color" color="danger">
<ion-breadcrumb href="#"> Home </ion-breadcrumb>
<ion-breadcrumb href="#electronics"> Electronics </ion-breadcrumb>
<ion-breadcrumb href="#photography"> Photography </ion-breadcrumb>
<ion-breadcrumb href="#cameras"> Cameras </ion-breadcrumb>
<ion-breadcrumb href="#film"> Film </ion-breadcrumb>
<ion-breadcrumb> 35 mm </ion-breadcrumb>
</ion-breadcrumbs>
</ion-content>
</ion-page>
</template>
<script lang="ts">
import {
IonPage,
IonHeader,
IonToolbar,
IonTitle,
IonContent,
IonBreadcrumbs,
} from "@ionic/vue";
import { defineComponent } from "vue";
export default defineComponent({
components: {
IonPage,
IonHeader,
IonToolbar,
IonTitle,
IonContent,
IonBreadcrumbs,
},
});
</script>

View File

@ -2,6 +2,9 @@
<ion-page> <ion-page>
<ion-content> <ion-content>
<ion-list> <ion-list>
<ion-item button router-link="/components/breadcrumbs">
<ion-label>Breadcrumbs</ion-label>
</ion-item>
<ion-item button router-link="/components/select"> <ion-item button router-link="/components/select">
<ion-label>Select</ion-label> <ion-label>Select</ion-label>
</ion-item> </ion-item>

View File

@ -0,0 +1,9 @@
describe("Components: Breadcrumbs", () => {
beforeEach(() => {
cy.visit("http://localhost:8080/components/breadcrumbs");
});
it("should have color attribute", () => {
cy.get('ion-breadcrumbs#color').should('have.prop', 'color');
});
});