From dc78f981531960791a425b3b1b81d45d5065a263 Mon Sep 17 00:00:00 2001 From: Ely Lucas Date: Thu, 16 Jan 2020 09:49:32 -0700 Subject: [PATCH] fix(react): updating icon type and add caret to internal icons (#20216) --- packages/react/src/components/IonIcon.tsx | 6 +++--- packages/react/src/components/index.ts | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/react/src/components/IonIcon.tsx b/packages/react/src/components/IonIcon.tsx index 6d9db46664..94bf38e62e 100644 --- a/packages/react/src/components/IonIcon.tsx +++ b/packages/react/src/components/IonIcon.tsx @@ -11,10 +11,10 @@ interface IonIconProps { ariaLabel?: string; color?: string; flipRtl?: boolean; - icon?: { ios: string; md: string; }; - ios?: { ios: string; md: string; }; + icon?: string; + ios?: string; lazy?: boolean; - md?: { ios: string; md: string; }; + md?: string; mode?: 'ios' | 'md'; name?: string; size?: string; diff --git a/packages/react/src/components/index.ts b/packages/react/src/components/index.ts index 6c5d09f275..6eac9a5580 100644 --- a/packages/react/src/components/index.ts +++ b/packages/react/src/components/index.ts @@ -1,7 +1,7 @@ import { defineCustomElements } from '@ionic/core/loader'; import { addIcons } from 'ionicons'; -import { arrowBackSharp, chevronBack, chevronForward, closeCircle, closeSharp, menuOutline, menuSharp, reorderThreeOutline, reorderTwoSharp, searchOutline, searchSharp } from 'ionicons/icons'; +import { arrowBackSharp, caretBackSharp, chevronBack, chevronForward, closeCircle, closeSharp, menuOutline, menuSharp, reorderThreeOutline, reorderTwoSharp, searchOutline, searchSharp } from 'ionicons/icons'; export { AlertButton, AlertInput, setupConfig } from '@ionic/core'; export * from './proxies'; @@ -31,6 +31,7 @@ export { RouterDirection } from './hrefprops'; // Icons that are used by internal components addIcons({ 'arrow-back-sharp': arrowBackSharp, + 'caret-back-sharp': caretBackSharp, 'chevron-back': chevronBack, 'chevron-forward': chevronForward, 'close-circle': closeCircle,