From dc0f701c3912e86c653c23b66eca95bd3f8f1e75 Mon Sep 17 00:00:00 2001
From: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Date: Thu, 27 Apr 2023 11:36:37 -0400
Subject: [PATCH] test(content): migrate to generators (#27302)

Issue number: N/A

---------

<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Content tests are using legacy syntax

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Content tests use generator syntax

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
---
 .../content/test/basic/content.e2e-legacy.ts   |  15 ---------------
 .../content/test/basic/content.e2e.ts          |  17 +++++++++++++++++
 ...content-diff-md-ltr-Mobile-Chrome-linux.png | Bin
 ...ontent-diff-md-ltr-Mobile-Firefox-linux.png | Bin
 ...content-diff-md-ltr-Mobile-Safari-linux.png | Bin
 .../content/test/fixed/content.e2e-legacy.ts   |  14 --------------
 .../content/test/fixed/content.e2e.ts          |  17 +++++++++++++++++
 ...ontent-fixed-md-ltr-Mobile-Chrome-linux.png | Bin
 ...ntent-fixed-md-ltr-Mobile-Firefox-linux.png | Bin
 ...ontent-fixed-md-ltr-Mobile-Safari-linux.png | Bin
 ...ontent-fixed-md-rtl-Mobile-Chrome-linux.png | Bin
 ...ntent-fixed-md-rtl-Mobile-Firefox-linux.png | Bin
 ...ontent-fixed-md-rtl-Mobile-Safari-linux.png | Bin
 .../test/fullscreen/content.e2e-legacy.ts      |  15 ---------------
 .../content/test/fullscreen/content.e2e.ts     |  17 +++++++++++++++++
 ...t-fullscreen-md-ltr-Mobile-Chrome-linux.png | Bin
 ...-fullscreen-md-ltr-Mobile-Firefox-linux.png | Bin
 ...t-fullscreen-md-ltr-Mobile-Safari-linux.png | Bin
 .../test/standalone/content.e2e-legacy.ts      |  13 -------------
 .../content/test/standalone/content.e2e.ts     |  15 +++++++++++++++
 ...t-standalone-md-ltr-Mobile-Chrome-linux.png | Bin
 ...-standalone-md-ltr-Mobile-Firefox-linux.png | Bin
 ...t-standalone-md-ltr-Mobile-Safari-linux.png | Bin
 23 files changed, 66 insertions(+), 57 deletions(-)
 delete mode 100644 core/src/components/content/test/basic/content.e2e-legacy.ts
 create mode 100644 core/src/components/content/test/basic/content.e2e.ts
 rename core/src/components/content/test/basic/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-diff-md-ltr-Mobile-Chrome-linux.png (100%)
 rename core/src/components/content/test/basic/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-diff-md-ltr-Mobile-Firefox-linux.png (100%)
 rename core/src/components/content/test/basic/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-diff-md-ltr-Mobile-Safari-linux.png (100%)
 delete mode 100644 core/src/components/content/test/fixed/content.e2e-legacy.ts
 create mode 100644 core/src/components/content/test/fixed/content.e2e.ts
 rename core/src/components/content/test/fixed/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fixed-md-ltr-Mobile-Chrome-linux.png (100%)
 rename core/src/components/content/test/fixed/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fixed-md-ltr-Mobile-Firefox-linux.png (100%)
 rename core/src/components/content/test/fixed/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fixed-md-ltr-Mobile-Safari-linux.png (100%)
 rename core/src/components/content/test/fixed/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fixed-md-rtl-Mobile-Chrome-linux.png (100%)
 rename core/src/components/content/test/fixed/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fixed-md-rtl-Mobile-Firefox-linux.png (100%)
 rename core/src/components/content/test/fixed/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fixed-md-rtl-Mobile-Safari-linux.png (100%)
 delete mode 100644 core/src/components/content/test/fullscreen/content.e2e-legacy.ts
 create mode 100644 core/src/components/content/test/fullscreen/content.e2e.ts
 rename core/src/components/content/test/fullscreen/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fullscreen-md-ltr-Mobile-Chrome-linux.png (100%)
 rename core/src/components/content/test/fullscreen/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fullscreen-md-ltr-Mobile-Firefox-linux.png (100%)
 rename core/src/components/content/test/fullscreen/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-fullscreen-md-ltr-Mobile-Safari-linux.png (100%)
 delete mode 100644 core/src/components/content/test/standalone/content.e2e-legacy.ts
 create mode 100644 core/src/components/content/test/standalone/content.e2e.ts
 rename core/src/components/content/test/standalone/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-standalone-md-ltr-Mobile-Chrome-linux.png (100%)
 rename core/src/components/content/test/standalone/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-standalone-md-ltr-Mobile-Firefox-linux.png (100%)
 rename core/src/components/content/test/standalone/{content.e2e-legacy.ts-snapshots => content.e2e.ts-snapshots}/content-standalone-md-ltr-Mobile-Safari-linux.png (100%)

diff --git a/core/src/components/content/test/basic/content.e2e-legacy.ts b/core/src/components/content/test/basic/content.e2e-legacy.ts
deleted file mode 100644
index 9af48d35cd..0000000000
--- a/core/src/components/content/test/basic/content.e2e-legacy.ts
+++ /dev/null
@@ -1,15 +0,0 @@
-import { expect } from '@playwright/test';
-import { test } from '@utils/test/playwright';
-
-test.describe('content: basic', () => {
-  test('should not have visual regressions', async ({ page, skip }) => {
-    skip.rtl();
-    skip.mode('ios', 'ion-content does not have mode-specific styling');
-
-    await page.goto(`/src/components/content/test/basic`);
-
-    await page.setIonViewport();
-
-    await expect(page).toHaveScreenshot(`content-diff-${page.getSnapshotSettings()}.png`);
-  });
-});
diff --git a/core/src/components/content/test/basic/content.e2e.ts b/core/src/components/content/test/basic/content.e2e.ts
new file mode 100644
index 0000000000..b9b322150e
--- /dev/null
+++ b/core/src/components/content/test/basic/content.e2e.ts
@@ -0,0 +1,17 @@
+import { expect } from '@playwright/test';
+import { configs, test } from '@utils/test/playwright';
+
+/**
+ * ion-content does not have mode-specific styling
+ */
+configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('content: basic'), () => {
+    test('should not have visual regressions', async ({ page }) => {
+      await page.goto(`/src/components/content/test/basic`, config);
+
+      await page.setIonViewport();
+
+      await expect(page).toHaveScreenshot(screenshot(`content-diff`));
+    });
+  });
+});
diff --git a/core/src/components/content/test/basic/content.e2e-legacy.ts-snapshots/content-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/content/test/basic/content.e2e-legacy.ts-snapshots/content-diff-md-ltr-Mobile-Chrome-linux.png
rename to core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Chrome-linux.png
diff --git a/core/src/components/content/test/basic/content.e2e-legacy.ts-snapshots/content-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/content/test/basic/content.e2e-legacy.ts-snapshots/content-diff-md-ltr-Mobile-Firefox-linux.png
rename to core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Firefox-linux.png
diff --git a/core/src/components/content/test/basic/content.e2e-legacy.ts-snapshots/content-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/content/test/basic/content.e2e-legacy.ts-snapshots/content-diff-md-ltr-Mobile-Safari-linux.png
rename to core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Safari-linux.png
diff --git a/core/src/components/content/test/fixed/content.e2e-legacy.ts b/core/src/components/content/test/fixed/content.e2e-legacy.ts
deleted file mode 100644
index 9438e6abbe..0000000000
--- a/core/src/components/content/test/fixed/content.e2e-legacy.ts
+++ /dev/null
@@ -1,14 +0,0 @@
-import { expect } from '@playwright/test';
-import { test } from '@utils/test/playwright';
-
-test.describe('content: fixed', () => {
-  test('should not have visual regressions', async ({ page, skip }) => {
-    skip.mode('ios', 'ion-content does not have mode-specific styling');
-
-    await page.goto(`/src/components/content/test/fixed`);
-
-    await page.setIonViewport();
-
-    await expect(page).toHaveScreenshot(`content-fixed-${page.getSnapshotSettings()}.png`);
-  });
-});
diff --git a/core/src/components/content/test/fixed/content.e2e.ts b/core/src/components/content/test/fixed/content.e2e.ts
new file mode 100644
index 0000000000..aaca95183a
--- /dev/null
+++ b/core/src/components/content/test/fixed/content.e2e.ts
@@ -0,0 +1,17 @@
+import { expect } from '@playwright/test';
+import { configs, test } from '@utils/test/playwright';
+
+/**
+ * ion-content does not have mode-specific styling
+ */
+configs({ modes: ['md'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('content: fixed'), () => {
+    test('should not have visual regressions', async ({ page }) => {
+      await page.goto(`/src/components/content/test/fixed`, config);
+
+      await page.setIonViewport();
+
+      await expect(page).toHaveScreenshot(screenshot(`content-fixed`));
+    });
+  });
+});
diff --git a/core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-ltr-Mobile-Chrome-linux.png b/core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-ltr-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-ltr-Mobile-Chrome-linux.png
rename to core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-ltr-Mobile-Chrome-linux.png
diff --git a/core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-ltr-Mobile-Firefox-linux.png b/core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-ltr-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-ltr-Mobile-Firefox-linux.png
rename to core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-ltr-Mobile-Firefox-linux.png
diff --git a/core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-ltr-Mobile-Safari-linux.png b/core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-ltr-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-ltr-Mobile-Safari-linux.png
rename to core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-ltr-Mobile-Safari-linux.png
diff --git a/core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-rtl-Mobile-Chrome-linux.png b/core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-rtl-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-rtl-Mobile-Chrome-linux.png
rename to core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-rtl-Mobile-Chrome-linux.png
diff --git a/core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-rtl-Mobile-Firefox-linux.png b/core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-rtl-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-rtl-Mobile-Firefox-linux.png
rename to core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-rtl-Mobile-Firefox-linux.png
diff --git a/core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-rtl-Mobile-Safari-linux.png b/core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-rtl-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/content/test/fixed/content.e2e-legacy.ts-snapshots/content-fixed-md-rtl-Mobile-Safari-linux.png
rename to core/src/components/content/test/fixed/content.e2e.ts-snapshots/content-fixed-md-rtl-Mobile-Safari-linux.png
diff --git a/core/src/components/content/test/fullscreen/content.e2e-legacy.ts b/core/src/components/content/test/fullscreen/content.e2e-legacy.ts
deleted file mode 100644
index 10bec37f24..0000000000
--- a/core/src/components/content/test/fullscreen/content.e2e-legacy.ts
+++ /dev/null
@@ -1,15 +0,0 @@
-import { expect } from '@playwright/test';
-import { test } from '@utils/test/playwright';
-
-test.describe('content: fullscreen', () => {
-  test('should not have visual regressions', async ({ page, skip }) => {
-    skip.rtl();
-    skip.mode('ios', 'ion-content does not have mode-specific styling');
-
-    await page.goto(`/src/components/content/test/fullscreen`);
-
-    await page.setIonViewport();
-
-    await expect(page).toHaveScreenshot(`content-fullscreen-${page.getSnapshotSettings()}.png`);
-  });
-});
diff --git a/core/src/components/content/test/fullscreen/content.e2e.ts b/core/src/components/content/test/fullscreen/content.e2e.ts
new file mode 100644
index 0000000000..d0d0d1f4e5
--- /dev/null
+++ b/core/src/components/content/test/fullscreen/content.e2e.ts
@@ -0,0 +1,17 @@
+import { expect } from '@playwright/test';
+import { configs, test } from '@utils/test/playwright';
+
+/**
+ * ion-content does not have mode-specific styling
+ */
+configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('content: fullscreen'), () => {
+    test('should not have visual regressions', async ({ page }) => {
+      await page.goto(`/src/components/content/test/fullscreen`, config);
+
+      await page.setIonViewport();
+
+      await expect(page).toHaveScreenshot(screenshot(`content-fullscreen`));
+    });
+  });
+});
diff --git a/core/src/components/content/test/fullscreen/content.e2e-legacy.ts-snapshots/content-fullscreen-md-ltr-Mobile-Chrome-linux.png b/core/src/components/content/test/fullscreen/content.e2e.ts-snapshots/content-fullscreen-md-ltr-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/content/test/fullscreen/content.e2e-legacy.ts-snapshots/content-fullscreen-md-ltr-Mobile-Chrome-linux.png
rename to core/src/components/content/test/fullscreen/content.e2e.ts-snapshots/content-fullscreen-md-ltr-Mobile-Chrome-linux.png
diff --git a/core/src/components/content/test/fullscreen/content.e2e-legacy.ts-snapshots/content-fullscreen-md-ltr-Mobile-Firefox-linux.png b/core/src/components/content/test/fullscreen/content.e2e.ts-snapshots/content-fullscreen-md-ltr-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/content/test/fullscreen/content.e2e-legacy.ts-snapshots/content-fullscreen-md-ltr-Mobile-Firefox-linux.png
rename to core/src/components/content/test/fullscreen/content.e2e.ts-snapshots/content-fullscreen-md-ltr-Mobile-Firefox-linux.png
diff --git a/core/src/components/content/test/fullscreen/content.e2e-legacy.ts-snapshots/content-fullscreen-md-ltr-Mobile-Safari-linux.png b/core/src/components/content/test/fullscreen/content.e2e.ts-snapshots/content-fullscreen-md-ltr-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/content/test/fullscreen/content.e2e-legacy.ts-snapshots/content-fullscreen-md-ltr-Mobile-Safari-linux.png
rename to core/src/components/content/test/fullscreen/content.e2e.ts-snapshots/content-fullscreen-md-ltr-Mobile-Safari-linux.png
diff --git a/core/src/components/content/test/standalone/content.e2e-legacy.ts b/core/src/components/content/test/standalone/content.e2e-legacy.ts
deleted file mode 100644
index 473a12665f..0000000000
--- a/core/src/components/content/test/standalone/content.e2e-legacy.ts
+++ /dev/null
@@ -1,13 +0,0 @@
-import { expect } from '@playwright/test';
-import { test } from '@utils/test/playwright';
-
-test.describe('content: standalone', () => {
-  test('should not have visual regressions', async ({ page, skip }) => {
-    skip.rtl();
-    skip.mode('ios', 'ion-content does not have mode-specific styling');
-
-    await page.goto(`/src/components/content/test/standalone`);
-
-    await expect(page).toHaveScreenshot(`content-standalone-${page.getSnapshotSettings()}.png`, { fullPage: true });
-  });
-});
diff --git a/core/src/components/content/test/standalone/content.e2e.ts b/core/src/components/content/test/standalone/content.e2e.ts
new file mode 100644
index 0000000000..0a35274bb2
--- /dev/null
+++ b/core/src/components/content/test/standalone/content.e2e.ts
@@ -0,0 +1,15 @@
+import { expect } from '@playwright/test';
+import { configs, test } from '@utils/test/playwright';
+
+/**
+ * ion-content does not have mode-specific styling
+ */
+configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('content: standalone'), () => {
+    test('should not have visual regressions', async ({ page }) => {
+      await page.goto(`/src/components/content/test/standalone`, config);
+
+      await expect(page).toHaveScreenshot(screenshot(`content-standalone`), { fullPage: true });
+    });
+  });
+});
diff --git a/core/src/components/content/test/standalone/content.e2e-legacy.ts-snapshots/content-standalone-md-ltr-Mobile-Chrome-linux.png b/core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/content/test/standalone/content.e2e-legacy.ts-snapshots/content-standalone-md-ltr-Mobile-Chrome-linux.png
rename to core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Chrome-linux.png
diff --git a/core/src/components/content/test/standalone/content.e2e-legacy.ts-snapshots/content-standalone-md-ltr-Mobile-Firefox-linux.png b/core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/content/test/standalone/content.e2e-legacy.ts-snapshots/content-standalone-md-ltr-Mobile-Firefox-linux.png
rename to core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Firefox-linux.png
diff --git a/core/src/components/content/test/standalone/content.e2e-legacy.ts-snapshots/content-standalone-md-ltr-Mobile-Safari-linux.png b/core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/content/test/standalone/content.e2e-legacy.ts-snapshots/content-standalone-md-ltr-Mobile-Safari-linux.png
rename to core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Safari-linux.png