diff --git a/packages/core/src/components/animation-controller/constants.ts b/packages/core/src/components/animation-controller/constants.ts index cf1ea313d2..839649d59c 100644 --- a/packages/core/src/components/animation-controller/constants.ts +++ b/packages/core/src/components/animation-controller/constants.ts @@ -12,7 +12,7 @@ export var CSS_PROP = function(docEle: HTMLElement) { var keys = ['webkitTransform', '-webkit-transform', 'webkit-transform', 'transform']; for (i = 0; i < keys.length; i++) { - if ((docEle.style)[keys[i]] !== undefined) { + if ((docEle.style as any)[keys[i]] !== undefined) { css.transformProp = keys[i]; break; } @@ -21,7 +21,7 @@ export var CSS_PROP = function(docEle: HTMLElement) { // transition keys = ['webkitTransition', 'transition']; for (i = 0; i < keys.length; i++) { - if ((docEle.style)[keys[i]] !== undefined) { + if ((docEle.style as any)[keys[i]] !== undefined) { css.transitionProp = keys[i]; break; } diff --git a/packages/core/src/components/datetime/datetime-util.ts b/packages/core/src/components/datetime/datetime-util.ts index c2720d7b83..45c30c3fdf 100644 --- a/packages/core/src/components/datetime/datetime-util.ts +++ b/packages/core/src/components/datetime/datetime-util.ts @@ -11,9 +11,9 @@ export function renderDatetime(template: string, value: DatetimeData, locale: Lo FORMAT_KEYS.forEach((format, index) => { if (template.indexOf(format.f) > -1) { var token = '{' + index + '}'; - var text = renderTextFormat(format.f, (value)[format.k], value, locale); + var text = renderTextFormat(format.f, (value as any)[format.k], value, locale); - if (!hasText && text && (value)[format.k]) { + if (!hasText && text && (value as any)[format.k]) { hasText = true; } @@ -259,7 +259,7 @@ export function updateDate(existingData: DatetimeData, newData: any): boolean { // merge new values from the picker's selection // to the existing DatetimeData values for (var k in newData) { - (existingData)[k] = newData[k].value; + (existingData as any)[k] = newData[k].value; } return true; @@ -271,7 +271,7 @@ export function updateDate(existingData: DatetimeData, newData: any): boolean { } else { // blank data, clear everything out for (let k in existingData) { - delete (existingData)[k]; + delete (existingData as any)[k]; } } return false; @@ -319,7 +319,7 @@ export function getValueFromFormat(date: DatetimeData, format: string) { if (format === FORMAT_hh || format === FORMAT_h) { return (date.hour > 12 ? date.hour - 12 : date.hour); } - return (date)[convertFormatToKey(format)]; + return (date as any)[convertFormatToKey(format)]; } diff --git a/packages/core/src/global/test/config-controller.spec.ts b/packages/core/src/global/test/config-controller.spec.ts new file mode 100644 index 0000000000..939c9e2a55 --- /dev/null +++ b/packages/core/src/global/test/config-controller.spec.ts @@ -0,0 +1,8 @@ +import { createConfigController } from '../config-controller'; + +describe('Config', () => { + it('should get a value from the config', () => { + let config = createConfigController({ name: 'Doc Brown' }, null); + expect(config.get('name')).toEqual('Doc Brown'); + }); +}); diff --git a/packages/core/src/global/test/query-param.spec.ts b/packages/core/src/global/test/query-param.spec.ts new file mode 100644 index 0000000000..f199444b90 --- /dev/null +++ b/packages/core/src/global/test/query-param.spec.ts @@ -0,0 +1,19 @@ +import { queryParam } from '../platform-configs'; + +describe('QueryParam', () => { + it('should read the url for a queryParam', () => { + let qp = queryParam('?boolean=false', 'boolean'); + expect(qp).toBeDefined(); + expect(qp).toEqual('false'); + }); + + it('should get the value of queryParam', () => { + let qp = queryParam('?keyValue=b', 'keyValue'); + expect(qp).toEqual('b'); + }); + + it('should show nullfor a queryParam this is not passed', () => { + let qp = queryParam('', 'ionicanimate'); + expect(qp).toBeNull(); + }); +}); diff --git a/packages/core/src/utils/helpers.ts b/packages/core/src/utils/helpers.ts index 6e0eb464ea..04a25295b9 100644 --- a/packages/core/src/utils/helpers.ts +++ b/packages/core/src/utils/helpers.ts @@ -155,7 +155,7 @@ export function applyStyles(elm: HTMLElement, styles: {[styleProp: string]: stri if (elm) { for (var i = 0; i < styleProps.length; i++) { - (elm.style)[styleProps[i]] = styles[styleProps[i]]; + (elm.style as any)[styleProps[i]] = styles[styleProps[i]]; } } }