mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-08 23:58:13 +08:00
Issue number: resolves ionic-team/ionic-docs#4145 --------- ## What is the current behavior? Some component methods are missing param tags in the JSDoc comments. Some comments are out of order and the method description is below the last param description. Some back ticks are misplaced around words resulting in incorrect formatting in the docs site. ## What is the new behavior? Method documentation in app, action-sheet, alert, datetime, loading, menu, modal, popover, reorder-group, router, searchbar, and toast now include descriptions for all params, all method descriptions are placed above param descriptions, and back ticks are formatted correctly. All changes are within JSDoc comments so will result in a change to the docs site but no functional change to any components. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information In order to preview these changes I took the JSON generated from the build on this branch and used it in the docusaurus script in place of the fetch from unpkg. I set up a preview from my fork on Vercel - https://ionic-docs-git-temptotestdocs-soundproofboots-projects.vercel.app/docs/components . The change I made to the docusaurus script to use this temp data is here - https://github.com/soundproofboot/ionic-docs/pull/1/files. tempDocs.json is the output of the framework build after making these changes. --------- Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com> Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com> Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
This commit is contained in:
@ -524,6 +524,8 @@ export class Datetime implements ComponentInterface {
|
||||
* Confirms the selected datetime value, updates the
|
||||
* `value` property, and optionally closes the popover
|
||||
* or modal that the datetime was presented in.
|
||||
*
|
||||
* @param closeOverlay If `true`, closes the parent overlay. Defaults to `false`.
|
||||
*/
|
||||
@Method()
|
||||
async confirm(closeOverlay = false) {
|
||||
@ -559,6 +561,8 @@ export class Datetime implements ComponentInterface {
|
||||
* Resets the internal state of the datetime but does not update the value.
|
||||
* Passing a valid ISO-8601 string will reset the state of the component to the provided date.
|
||||
* If no value is provided, the internal state will be reset to the clamped value of the min, max and today.
|
||||
*
|
||||
* @param startDate A valid [ISO-8601 string](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date#date_time_string_format) to reset the datetime state to.
|
||||
*/
|
||||
@Method()
|
||||
async reset(startDate?: string) {
|
||||
@ -570,6 +574,8 @@ export class Datetime implements ComponentInterface {
|
||||
* optionally closes the popover
|
||||
* or modal that the datetime was
|
||||
* presented in.
|
||||
*
|
||||
* @param closeOverlay If `true`, closes the parent overlay. Defaults to `false`.
|
||||
*/
|
||||
@Method()
|
||||
async cancel(closeOverlay = false) {
|
||||
|
||||
Reference in New Issue
Block a user