javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(datetime): fix flaky test (#26874)

Browse Source
This commit is contained in:
Liam DeBeasi
2023-02-28 15:15:48 -05:00
committed by GitHub
parent 7c57b4f39e
commit db6eb35463
1 changed files with 29 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
core/src/components/datetime/test/presentation/datetime.e2e.ts
View File

@@ -108,45 +108,42 @@ test.describe('datetime: presentation', () => {
});
});
// TODO: FW-3018
test.skip('datetime: presentation: time', () => {
let timePickerFixture: TimePickerFixture;
test.beforeEach(async ({ page }) => {
timePickerFixture = new TimePickerFixture(page);
await timePickerFixture.goto();
test.describe('datetime: presentation: time', () => {
test.beforeEach(async ({ skip }) => {
skip.rtl();
skip.mode('md');
});
test('changing value from AM to AM should update the text', async () => {
await timePickerFixture.setValue('04:20:00');
await timePickerFixture.expectTime('4', '20', 'AM');
test('changing value from AM to AM should update the text', async ({ page }) => {
const timePickerFixture = new TimePickerFixture(page);
await timePickerFixture.goto('04:20:00');
await timePickerFixture.setValue('11:03:00');
await timePickerFixture.expectTime('11', '03', 'AM');
await timePickerFixture.expectTime(11, 3, 'am');
});
test('changing value from AM to PM should update the text', async () => {
await timePickerFixture.setValue('05:30:00');
await timePickerFixture.expectTime('5', '30', 'AM');
test('changing value from AM to PM should update the text', async ({ page }) => {
const timePickerFixture = new TimePickerFixture(page);
await timePickerFixture.goto('05:30:00');
await timePickerFixture.setValue('16:40:00');
await timePickerFixture.expectTime('4', '40', 'PM');
await timePickerFixture.expectTime(16, 40, 'pm');
});
test('changing the value from PM to AM should update the text', async () => {
await timePickerFixture.setValue('16:40:00');
await timePickerFixture.expectTime('4', '40', 'PM');
test('changing the value from PM to AM should update the text', async ({ page }) => {
const timePickerFixture = new TimePickerFixture(page);
await timePickerFixture.goto('16:40:00');
await timePickerFixture.setValue('04:20:00');
await timePickerFixture.expectTime('4', '20', 'AM');
await timePickerFixture.expectTime(4, 20, 'am');
});
test('changing the value from PM to PM should update the text', async () => {
await timePickerFixture.setValue('16:40:00');
await timePickerFixture.expectTime('4', '40', 'PM');
test('changing the value from PM to PM should update the text', async ({ page }) => {
const timePickerFixture = new TimePickerFixture(page);
await timePickerFixture.goto('16:40:00');
await timePickerFixture.setValue('19:32:00');
await timePickerFixture.expectTime('7', '32', 'PM');
await timePickerFixture.expectTime(19, 32, 'pm');
});
});
@@ -159,35 +156,27 @@ class TimePickerFixture {
this.page = page;
}
async goto() {
async goto(value: string) {
await this.page.setContent(`
<ion-datetime presentation="time" value="2022-03-10T13:00:00"></ion-datetime>
<ion-datetime presentation="time" value="${value}"></ion-datetime>
`);
await this.page.waitForSelector('.datetime-ready');
this.timePicker = this.page.locator('ion-datetime');
}
async setValue(value: string) {
const ionChange = await this.page.spyOnEvent('ionChange');
await this.timePicker.evaluate((el: HTMLIonDatetimeElement, newValue: string) => {
el.value = newValue;
}, value);
await ionChange.next();
// Changing the value can take longer than the default 100ms to repaint
await this.page.waitForChanges(300);
await this.page.waitForChanges();
}
async expectTime(hour: string, minute: string, ampm: string) {
expect(
await this.timePicker.locator('ion-picker-column-internal:nth-child(1) .picker-item-active').textContent()
).toBe(hour);
expect(
await this.timePicker.locator('ion-picker-column-internal:nth-child(2) .picker-item-active').textContent()
).toBe(minute);
expect(
await this.timePicker.locator('ion-picker-column-internal:nth-child(3) .picker-item-active').textContent()
).toBe(ampm);
async expectTime(hour: number, minute: number, ampm: string) {
const pickerColumns = this.timePicker.locator('ion-picker-column-internal');
await expect(pickerColumns.nth(0)).toHaveJSProperty('value', hour);
await expect(pickerColumns.nth(1)).toHaveJSProperty('value', minute);
await expect(pickerColumns.nth(2)).toHaveJSProperty('value', ampm);
}
}