javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 22:17:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(input): revert previous type change

Browse Source 
This reverts commit 3a562282909fddf8cfa65199f9154504f3da0f3a.
This commit is contained in:
Liam DeBeasi
2020-01-24 16:03:03 -05:00
committed by GitHub
parent 1bfc1c0393
commit db1fd1d72a
4 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/api.txt
View File

@ -449,7 +449,7 @@ ion-input,prop,size,number | undefined,undefined,false,false
ion-input,prop,spellcheck,boolean,false,false,false
ion-input,prop,step,string | undefined,undefined,false,false
ion-input,prop,type,"date" | "email" | "number" | "password" | "search" | "tel" | "text" | "time" | "url",'text',false,false
ion-input,prop,value,null | number | string | undefined,'',false,false
ion-input,prop,value,null | string | undefined,'',false,false
ion-input,method,getInputElement,getInputElement() => Promise<HTMLInputElement>
ion-input,method,setFocus,setFocus() => Promise<void>
ion-input,event,ionBlur,void,true

4
core/src/components.d.ts vendored
View File

@ -1037,7 +1037,7 @@ export namespace Components {
/**
* The value of the input.
*/
'value'?: string | number | null;
'value'?: string | null;
}
interface IonItem {
/**
@ -4576,7 +4576,7 @@ declare namespace LocalJSX {
/**
* The value of the input.
*/
'value'?: string | number | null;
'value'?: string | null;
}
interface IonItem {
/**

7
core/src/components/input/input.tsx
View File

@ -169,7 +169,7 @@ export class Input implements ComponentInterface {
/**
* The value of the input.
*/
@Prop({ mutable: true }) value?: string | number | null = '';
@Prop({ mutable: true }) value?: string | null = '';
/**
* Update the native input element when the value changes
@ -177,7 +177,7 @@ export class Input implements ComponentInterface {
@Watch('value')
protected valueChanged() {
this.emitStyle();
this.ionChange.emit({ value: this.value == null ? this.value : this.value.toString() });
this.ionChange.emit({ value: this.value });
}
/**
@ -263,8 +263,7 @@ export class Input implements ComponentInterface {
}
private getValue(): string {
return typeof this.value === 'number' ? this.value.toString() :
(this.value || '').toString();
return this.value || '';
}
private emitStyle() {

2
core/src/components/input/readme.md
View File

@ -238,7 +238,7 @@ export const InputExample: React.FC = () => (
| `spellcheck` | `spellcheck` | If `true`, the element will have its spelling and grammar checked. | `boolean` | `false` |
| `step` | `step` | Works with the min and max attributes to limit the increments at which a value can be set. Possible values are: `"any"` or a positive floating point number. | `string \| undefined` | `undefined` |
| `type` | `type` | The type of control to display. The default type is text. | `"date" \| "email" \| "number" \| "password" \| "search" \| "tel" \| "text" \| "time" \| "url"` | `'text'` |
| `value` | `value` | The value of the input. | `null \| number \| string \| undefined` | `''` |
| `value` | `value` | The value of the input. | `null \| string \| undefined` | `''` |
## Events