javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 10:41:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(vue): correctly switch tabs after going back (#22309)

Browse Source 
resolves #22307
This commit is contained in:
Liam DeBeasi
2020-11-04 12:50:31 -05:00
committed by GitHub
parent a9b2260100
commit daf6a92127
6 changed files with 188 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/vue/test-app/src/views/Tab1.vue
View File

@ -17,7 +17,7 @@
<ExploreContainer name="Tab 1 page" />
<ion-item router-link="tab1/child-one" id="child-one">
<ion-item router-link="/tabs/tab1/child-one" id="child-one">
<ion-label>Go to Tab 1 Child 1</ion-label>
</ion-item>
<ion-item router-link="/nested" id="nested">

2
packages/vue/test-app/src/views/Tab3Secondary.vue
View File

@ -1,5 +1,5 @@
<template>
<ion-page>
<ion-page data-pageid="tab3-secondary">
<ion-header>
<ion-toolbar>
<ion-title>Tab 3 - Secondary</ion-title>

25
packages/vue/test-app/tests/e2e/specs/tabs.js
View File

@ -122,6 +122,31 @@ describe('Tabs', () => {
cy.ionPageDoesNotExist('tab3');
cy.ionPageVisible('tabs');
});
// Verifies fix for https://github.com/ionic-team/ionic-framework/issues/22307
it('should select correct tab after going back', () => {
cy.visit('http://localhost:8080/tabs-secondary/tab1');
cy.get('ion-tab-button#tab-button-tab2-secondary').click();
cy.ionPageVisible('tab2-secondary');
cy.ionPageHidden('tab1-secondary');
cy.get('ion-tab-button#tab-button-tab3-secondary').click();
cy.ionPageVisible('tab3-secondary');
cy.ionPageHidden('tab2-secondary');
cy.go('back');
cy.ionPageVisible('tab2-secondary');
cy.ionPageHidden('tab3-secondary');
cy.go('back');
cy.ionPageVisible('tab1-secondary');
cy.ionPageHidden('tab2-secondary');
cy.get('ion-tab-button#tab-button-tab3-secondary').click();
cy.ionPageVisible('tab3-secondary');
cy.ionPageHidden('tab1-secondary');
});
})
describe('Tabs - Swipe to Go Back', () => {