javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs): initialize select in the willLoad before the select call is made (#18300)

Browse Source 
#17957
This commit is contained in:
Brandy Carney
2019-05-20 11:26:46 -04:00
committed by GitHub
parent fa87e35a05
commit da38647478
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/components/tabs/tabs.tsx
View File

@ -49,14 +49,11 @@ export class Tabs implements NavOutlet {
this.useRouter = !!this.doc.querySelector('ion-router') && !this.el.closest('[no-router]'); this.useRouter = !!this.doc.querySelector('ion-router') && !this.el.closest('[no-router]');
} }
this.tabs = Array.from(this.el.querySelectorAll('ion-tab')); this.tabs = Array.from(this.el.querySelectorAll('ion-tab'));
await this.initSelect();
this.ionNavWillLoad.emit(); this.ionNavWillLoad.emit();
this.componentWillUpdate(); this.componentWillUpdate();
} }
componentDidLoad() {
this.initSelect();
}
componentDidUnload() { componentDidUnload() {
this.tabs.length = 0; this.tabs.length = 0;
this.selectedTab = this.leavingTab = undefined; this.selectedTab = this.leavingTab = undefined;
@ -156,6 +153,7 @@ export class Tabs implements NavOutlet {
} }
// wait for all tabs to be ready // wait for all tabs to be ready
await Promise.all(this.tabs.map(tab => tab.componentOnReady())); await Promise.all(this.tabs.map(tab => tab.componentOnReady()));
await this.select(this.tabs[0]); await this.select(this.tabs[0]);
} }