javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 01:03:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(toolbar): fix flaky tests for toolbar

Browse Source
This commit is contained in:
Brandy Smith
2025-08-05 17:37:46 -04:00
parent 0f2c69804d
commit d9eb400a00
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/components/toolbar/test/basic/toolbar.e2e.ts
View File

@ -86,7 +86,9 @@ configs({ modes: ['ios', 'md', 'ionic-md'], palettes: ['light', 'dark'] }).forEa
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-icon-buttons`)); await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-icon-buttons`));
}); });
test('should not have visual regressions with buttons with icons and text', async ({ page }) => { test('should not have visual regressions with buttons with icons and text', async ({ page, skip }) => {
skip.browser('webkit', 'Safari does not consistently render overflowing text in a toolbar with icons and text.');
await page.setContent( await page.setContent(
` `
<ion-header> <ion-header>
@ -216,6 +218,10 @@ configs({ modes: ['ios', 'md', 'ionic-md'], directions: ['ltr'] }).forEach(({ ti
config config
); );
// Wait for images to be visible
await page.locator('img').first().waitFor({ state: 'visible' });
await page.locator('ion-img').first().waitFor({ state: 'visible' });
const header = page.locator('ion-header'); const header = page.locator('ion-header');
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-slotted-images`)); await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-slotted-images`));
}); });
@ -238,6 +244,10 @@ configs({ modes: ['ios', 'md', 'ionic-md'], directions: ['ltr'] }).forEach(({ ti
config config
); );
// Wait for images to be visible
await page.locator('img').first().waitFor({ state: 'visible' });
await page.locator('ion-img').first().waitFor({ state: 'visible' });
const header = page.locator('ion-header'); const header = page.locator('ion-header');
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-nested-slotted-images`)); await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-nested-slotted-images`));
}); });