javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 10:01:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): inline overlays display contents consistently (#26255)

Browse Source 
Resolves #26253
This commit is contained in:
Sean Perkins
2022-11-09 13:25:44 -05:00
committed by GitHub
parent 16e882f46c
commit d709ff64ae
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/react/src/components/createInlineOverlayComponent.tsx
View File

@ -144,6 +144,7 @@ export const createInlineOverlayComponent = <PropType, ElementType>(
{
id: 'ion-react-wrapper',
ref: this.wrapperRef,
className: 'ion-delegate-host',
style: {
display: 'flex',
flexDirection: 'column',

19
packages/react/test-app/tests/e2e/specs/overlay-components/KeepContentsMounted.cy.ts
View File

@ -27,6 +27,25 @@ describe('keepContentsMounted', () => {
cy.get('ion-modal ion-content').should('exist');
});
it('should display contents consistently on re-open', () => {
// https://github.com/ionic-team/ionic-framework/issues/26253
cy.visit('/keep-contents-mounted');
cy.get('#open-modal').click();
cy.get('ion-modal ion-content').should('exist');
cy.get('ion-modal ion-button').click();
cy.get('ion-modal')
.should('not.be.visible')
.should('have.class', 'overlay-hidden');
cy.get('#open-modal').click();
cy.get('ion-modal ion-button').should('be.visible');
})
})
describe('popover', () => {
it('should not mount component if false', () => {