From d67fdcc43a96054059b338d504aef51555293515 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 15 Mar 2024 12:03:30 -0400 Subject: [PATCH] test(item): use themes options in config (#29168) Issue number: Internal --------- ## What is the current behavior? In https://github.com/ionic-team/ionic-framework/pull/27134 we fixed a bug for item button colors on dark mode. We added a test for this in dark mode, but it was created before we had the infrastructure to test dark mode within Playwright. As a result, the dark mode theme is hard coded into the test. ## What is the new behavior? - This test has been simplified to only test the things we need to test - It also relies on the built-in dark theme testing instead of hard coding the theme. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --------- Co-authored-by: ionitron --- .../components/item/test/buttons/index.html | 165 ------------------ .../components/item/test/buttons/item.e2e.ts | 28 ++- ...-dark-diff-ios-ltr-Mobile-Chrome-linux.png | Bin 72476 -> 0 bytes ...dark-diff-ios-ltr-Mobile-Firefox-linux.png | Bin 84331 -> 0 bytes ...-dark-diff-ios-ltr-Mobile-Safari-linux.png | Bin 63851 -> 0 bytes ...-diff-ios-ltr-dark-Mobile-Chrome-linux.png | Bin 0 -> 7909 bytes ...diff-ios-ltr-dark-Mobile-Firefox-linux.png | Bin 0 -> 8163 bytes ...-diff-ios-ltr-dark-Mobile-Safari-linux.png | Bin 0 -> 7014 bytes ...s-dark-diff-md-ltr-Mobile-Chrome-linux.png | Bin 67972 -> 0 bytes ...-dark-diff-md-ltr-Mobile-Firefox-linux.png | Bin 80546 -> 0 bytes ...s-dark-diff-md-ltr-Mobile-Safari-linux.png | Bin 58161 -> 0 bytes ...k-diff-md-ltr-dark-Mobile-Chrome-linux.png | Bin 0 -> 6974 bytes ...-diff-md-ltr-dark-Mobile-Firefox-linux.png | Bin 0 -> 7560 bytes ...k-diff-md-ltr-dark-Mobile-Safari-linux.png | Bin 0 -> 5932 bytes 14 files changed, 24 insertions(+), 169 deletions(-) delete mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-ios-ltr-Mobile-Chrome-linux.png delete mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-ios-ltr-Mobile-Firefox-linux.png delete mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-ios-ltr-Mobile-Safari-linux.png create mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-ios-ltr-dark-Mobile-Chrome-linux.png create mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-ios-ltr-dark-Mobile-Firefox-linux.png create mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-ios-ltr-dark-Mobile-Safari-linux.png delete mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-md-ltr-Mobile-Chrome-linux.png delete mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-md-ltr-Mobile-Firefox-linux.png delete mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-md-ltr-Mobile-Safari-linux.png create mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-md-ltr-dark-Mobile-Chrome-linux.png create mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-md-ltr-dark-Mobile-Firefox-linux.png create mode 100644 core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-dark-diff-md-ltr-dark-Mobile-Safari-linux.png diff --git a/core/src/components/item/test/buttons/index.html b/core/src/components/item/test/buttons/index.html index d28eafee33..fb8d5449ca 100644 --- a/core/src/components/item/test/buttons/index.html +++ b/core/src/components/item/test/buttons/index.html @@ -12,165 +12,6 @@ - - @@ -347,12 +188,6 @@