mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-08 15:51:16 +08:00
fix(config): allow LogLevel to work with isolatedModules and update all warns and errors to respect logLevel (#30350)
Issue number: internal --------- ## What is the current behavior? - `LogLevel` throws error `Error: Cannot access ambient const enums when 'isolatedModules' is enabled` - Several existing console warns and errors are not calling the function that respects the `logLevel` config ## What is the new behavior? - Remove `const` from the `enum` to work with `isolatedModules` - Update `console.warn`s to `printIonWarning` - Update `console.error`s to `printIonError` ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Dev build: `8.5.5-dev.11744729748.174bf7e0` --------- Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
This commit is contained in:
@ -1,4 +1,5 @@
|
||||
import { getMode, setMode } from '@stencil/core';
|
||||
import { printIonWarning } from '@utils/logging';
|
||||
|
||||
import type { IonicConfig, Mode } from '../interface';
|
||||
import { isPlatform, setupPlatforms } from '../utils/platform';
|
||||
@ -67,7 +68,7 @@ export const initialize = (userConfig: IonicConfig = {}) => {
|
||||
if (isAllowedIonicModeValue(elmMode)) {
|
||||
return elmMode;
|
||||
} else if (isIonicElement(elm)) {
|
||||
console.warn('Invalid ionic mode: "' + elmMode + '", expected: "ios" or "md"');
|
||||
printIonWarning('Invalid ionic mode: "' + elmMode + '", expected: "ios" or "md"');
|
||||
}
|
||||
}
|
||||
elm = elm.parentElement;
|
||||
|
||||
Reference in New Issue
Block a user