From d4dc29b1bcf117e36b066bdce1d8f6669e0edd92 Mon Sep 17 00:00:00 2001
From: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Date: Fri, 28 Apr 2023 11:12:15 -0400
Subject: [PATCH] test(icon): migrate to generators (#27318)

Issue number: N/A

---------

<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Icon tests use legacy syntax

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Icon tests use modern syntax

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
---
 .../icon/test/basic/icon.e2e-legacy.ts        |  16 ----------
 .../components/icon/test/basic/icon.e2e.ts    |  18 +++++++++++
 .../icon-md-ltr-Mobile-Chrome-linux.png       | Bin
 .../icon-md-ltr-Mobile-Firefox-linux.png      | Bin
 .../icon-md-ltr-Mobile-Safari-linux.png       | Bin
 .../icon/test/dir/icon.e2e-legacy.ts          |  25 ---------------
 core/src/components/icon/test/dir/icon.e2e.ts |  29 ++++++++++++++++++
 .../icon-flip-md-ltr-Mobile-Chrome-linux.png  | Bin
 .../icon-flip-md-ltr-Mobile-Firefox-linux.png | Bin
 .../icon-flip-md-ltr-Mobile-Safari-linux.png  | Bin
 .../icon-flip-md-rtl-Mobile-Chrome-linux.png  | Bin
 .../icon-flip-md-rtl-Mobile-Firefox-linux.png | Bin
 .../icon-flip-md-rtl-Mobile-Safari-linux.png  | Bin
 ...con-no-flip-md-ltr-Mobile-Chrome-linux.png | Bin
 ...on-no-flip-md-ltr-Mobile-Firefox-linux.png | Bin
 ...con-no-flip-md-ltr-Mobile-Safari-linux.png | Bin
 ...con-no-flip-md-rtl-Mobile-Chrome-linux.png | Bin
 ...on-no-flip-md-rtl-Mobile-Firefox-linux.png | Bin
 ...con-no-flip-md-rtl-Mobile-Safari-linux.png | Bin
 19 files changed, 47 insertions(+), 41 deletions(-)
 delete mode 100644 core/src/components/icon/test/basic/icon.e2e-legacy.ts
 create mode 100644 core/src/components/icon/test/basic/icon.e2e.ts
 rename core/src/components/icon/test/basic/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-md-ltr-Mobile-Chrome-linux.png (100%)
 rename core/src/components/icon/test/basic/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-md-ltr-Mobile-Firefox-linux.png (100%)
 rename core/src/components/icon/test/basic/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-md-ltr-Mobile-Safari-linux.png (100%)
 delete mode 100644 core/src/components/icon/test/dir/icon.e2e-legacy.ts
 create mode 100644 core/src/components/icon/test/dir/icon.e2e.ts
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-flip-md-ltr-Mobile-Chrome-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-flip-md-ltr-Mobile-Firefox-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-flip-md-ltr-Mobile-Safari-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-flip-md-rtl-Mobile-Chrome-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-flip-md-rtl-Mobile-Firefox-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-flip-md-rtl-Mobile-Safari-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-no-flip-md-ltr-Mobile-Chrome-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-no-flip-md-ltr-Mobile-Firefox-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-no-flip-md-ltr-Mobile-Safari-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-no-flip-md-rtl-Mobile-Chrome-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-no-flip-md-rtl-Mobile-Firefox-linux.png (100%)
 rename core/src/components/icon/test/dir/{icon.e2e-legacy.ts-snapshots => icon.e2e.ts-snapshots}/icon-no-flip-md-rtl-Mobile-Safari-linux.png (100%)

diff --git a/core/src/components/icon/test/basic/icon.e2e-legacy.ts b/core/src/components/icon/test/basic/icon.e2e-legacy.ts
deleted file mode 100644
index fd6cb493aa..0000000000
--- a/core/src/components/icon/test/basic/icon.e2e-legacy.ts
+++ /dev/null
@@ -1,16 +0,0 @@
-import { expect } from '@playwright/test';
-import { test } from '@utils/test/playwright';
-
-test.describe('icon: basic', () => {
-  test('should render icon when passed', async ({ page, skip }) => {
-    skip.rtl();
-    skip.mode('ios');
-
-    await page.setContent(`
-      <ion-icon name="star"></ion-icon>
-    `);
-
-    const icon = page.locator('ion-icon');
-    await expect(icon).toHaveScreenshot(`icon-${page.getSnapshotSettings()}.png`);
-  });
-});
diff --git a/core/src/components/icon/test/basic/icon.e2e.ts b/core/src/components/icon/test/basic/icon.e2e.ts
new file mode 100644
index 0000000000..35e592b737
--- /dev/null
+++ b/core/src/components/icon/test/basic/icon.e2e.ts
@@ -0,0 +1,18 @@
+import { expect } from '@playwright/test';
+import { configs, test } from '@utils/test/playwright';
+
+configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('icon: basic'), () => {
+    test('should render icon when passed', async ({ page }) => {
+      await page.setContent(
+        `
+        <ion-icon name="star"></ion-icon>
+      `,
+        config
+      );
+
+      const icon = page.locator('ion-icon');
+      await expect(icon).toHaveScreenshot(screenshot(`icon`));
+    });
+  });
+});
diff --git a/core/src/components/icon/test/basic/icon.e2e-legacy.ts-snapshots/icon-md-ltr-Mobile-Chrome-linux.png b/core/src/components/icon/test/basic/icon.e2e.ts-snapshots/icon-md-ltr-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/icon/test/basic/icon.e2e-legacy.ts-snapshots/icon-md-ltr-Mobile-Chrome-linux.png
rename to core/src/components/icon/test/basic/icon.e2e.ts-snapshots/icon-md-ltr-Mobile-Chrome-linux.png
diff --git a/core/src/components/icon/test/basic/icon.e2e-legacy.ts-snapshots/icon-md-ltr-Mobile-Firefox-linux.png b/core/src/components/icon/test/basic/icon.e2e.ts-snapshots/icon-md-ltr-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/icon/test/basic/icon.e2e-legacy.ts-snapshots/icon-md-ltr-Mobile-Firefox-linux.png
rename to core/src/components/icon/test/basic/icon.e2e.ts-snapshots/icon-md-ltr-Mobile-Firefox-linux.png
diff --git a/core/src/components/icon/test/basic/icon.e2e-legacy.ts-snapshots/icon-md-ltr-Mobile-Safari-linux.png b/core/src/components/icon/test/basic/icon.e2e.ts-snapshots/icon-md-ltr-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/icon/test/basic/icon.e2e-legacy.ts-snapshots/icon-md-ltr-Mobile-Safari-linux.png
rename to core/src/components/icon/test/basic/icon.e2e.ts-snapshots/icon-md-ltr-Mobile-Safari-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts b/core/src/components/icon/test/dir/icon.e2e-legacy.ts
deleted file mode 100644
index 7315df675e..0000000000
--- a/core/src/components/icon/test/dir/icon.e2e-legacy.ts
+++ /dev/null
@@ -1,25 +0,0 @@
-import { expect } from '@playwright/test';
-import { test } from '@utils/test/playwright';
-
-test.describe('icon: rtl', () => {
-  test('should flip icon when rtl is active', async ({ page, skip }) => {
-    skip.mode('ios');
-
-    await page.setContent(`
-      <ion-icon name="cut" flip-rtl="true"></ion-icon>
-    `);
-
-    const icon = page.locator('ion-icon');
-    await expect(icon).toHaveScreenshot(`icon-flip-${page.getSnapshotSettings()}.png`);
-  });
-  test('should not flip icon when rtl is active', async ({ page, skip }) => {
-    skip.mode('ios');
-
-    await page.setContent(`
-      <ion-icon name="cut" flip-rtl="false"></ion-icon>
-    `);
-
-    const icon = page.locator('ion-icon');
-    await expect(icon).toHaveScreenshot(`icon-no-flip-${page.getSnapshotSettings()}.png`);
-  });
-});
diff --git a/core/src/components/icon/test/dir/icon.e2e.ts b/core/src/components/icon/test/dir/icon.e2e.ts
new file mode 100644
index 0000000000..1d1ddbdb0f
--- /dev/null
+++ b/core/src/components/icon/test/dir/icon.e2e.ts
@@ -0,0 +1,29 @@
+import { expect } from '@playwright/test';
+import { configs, test } from '@utils/test/playwright';
+
+configs({ modes: ['md'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('icon: rtl'), () => {
+    test('should flip icon when rtl is active', async ({ page }) => {
+      await page.setContent(
+        `
+        <ion-icon name="cut" flip-rtl="true"></ion-icon>
+      `,
+        config
+      );
+
+      const icon = page.locator('ion-icon');
+      await expect(icon).toHaveScreenshot(screenshot(`icon-flip`));
+    });
+    test('should not flip icon when rtl is active', async ({ page }) => {
+      await page.setContent(
+        `
+        <ion-icon name="cut" flip-rtl="false"></ion-icon>
+      `,
+        config
+      );
+
+      const icon = page.locator('ion-icon');
+      await expect(icon).toHaveScreenshot(screenshot(`icon-no-flip`));
+    });
+  });
+});
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-ltr-Mobile-Chrome-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-ltr-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-ltr-Mobile-Chrome-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-ltr-Mobile-Chrome-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-ltr-Mobile-Firefox-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-ltr-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-ltr-Mobile-Firefox-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-ltr-Mobile-Firefox-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-ltr-Mobile-Safari-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-ltr-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-ltr-Mobile-Safari-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-ltr-Mobile-Safari-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-rtl-Mobile-Chrome-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-rtl-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-rtl-Mobile-Chrome-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-rtl-Mobile-Chrome-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-rtl-Mobile-Firefox-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-rtl-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-rtl-Mobile-Firefox-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-rtl-Mobile-Firefox-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-rtl-Mobile-Safari-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-rtl-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-flip-md-rtl-Mobile-Safari-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-flip-md-rtl-Mobile-Safari-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-ltr-Mobile-Chrome-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-ltr-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-ltr-Mobile-Chrome-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-ltr-Mobile-Chrome-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-ltr-Mobile-Firefox-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-ltr-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-ltr-Mobile-Firefox-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-ltr-Mobile-Firefox-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-ltr-Mobile-Safari-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-ltr-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-ltr-Mobile-Safari-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-ltr-Mobile-Safari-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-rtl-Mobile-Chrome-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-rtl-Mobile-Chrome-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-rtl-Mobile-Chrome-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-rtl-Mobile-Chrome-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-rtl-Mobile-Firefox-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-rtl-Mobile-Firefox-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-rtl-Mobile-Firefox-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-rtl-Mobile-Firefox-linux.png
diff --git a/core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-rtl-Mobile-Safari-linux.png b/core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-rtl-Mobile-Safari-linux.png
similarity index 100%
rename from core/src/components/icon/test/dir/icon.e2e-legacy.ts-snapshots/icon-no-flip-md-rtl-Mobile-Safari-linux.png
rename to core/src/components/icon/test/dir/icon.e2e.ts-snapshots/icon-no-flip-md-rtl-Mobile-Safari-linux.png