mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-17 10:41:13 +08:00
chore(ci): ensure stencil nightly gets installed for spec tests (#27974)
Issue number: # --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Stencil v3.4 is being used in the nightly run of these tests ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> this commit updates the `test-core-spec` action to accept an argument for the version of stencil that should be installed/used. since we do not (and arguably, should not) cache `node_modules/`, we need a way to inform this action that a nightly version of stencil should be installed ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information I fully expect nightly CI to begin to fail as a result of merging this. We'll fix that next week (in Stencil) <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
This commit is contained in:
@ -14,6 +14,6 @@ runs:
|
|||||||
with:
|
with:
|
||||||
name: ${{ inputs.name }}
|
name: ${{ inputs.name }}
|
||||||
path: ${{ inputs.path }}
|
path: ${{ inputs.path }}
|
||||||
- name: Exract Archive
|
- name: Extract Archive
|
||||||
run: unzip -q -o ${{ inputs.path }}/${{ inputs.filename }}
|
run: unzip -q -o ${{ inputs.path }}/${{ inputs.filename }}
|
||||||
shell: bash
|
shell: bash
|
||||||
|
@ -1,5 +1,8 @@
|
|||||||
name: 'Test Core Spec'
|
name: 'Test Core Spec'
|
||||||
description: 'Test Core Spec'
|
description: 'Test Core Spec'
|
||||||
|
inputs:
|
||||||
|
stencil-version:
|
||||||
|
description: 'The NPM tag of @stencil/core to install.'
|
||||||
runs:
|
runs:
|
||||||
using: 'composite'
|
using: 'composite'
|
||||||
steps:
|
steps:
|
||||||
@ -7,9 +10,14 @@ runs:
|
|||||||
with:
|
with:
|
||||||
node-version: 16.x
|
node-version: 16.x
|
||||||
- name: Install Dependencies
|
- name: Install Dependencies
|
||||||
run: npm install
|
run: npm ci
|
||||||
working-directory: ./core
|
working-directory: ./core
|
||||||
shell: bash
|
shell: bash
|
||||||
|
- name: Install Stencil ${{ inputs.stencil-version }}
|
||||||
|
run: npm install @stencil/core@${{ inputs.stencil-version }}
|
||||||
|
shell: bash
|
||||||
|
working-directory: ./core
|
||||||
|
if: ${{ inputs.stencil-version != '' }}
|
||||||
- uses: ./.github/workflows/actions/download-archive
|
- uses: ./.github/workflows/actions/download-archive
|
||||||
with:
|
with:
|
||||||
name: ionic-core
|
name: ionic-core
|
||||||
|
2
.github/workflows/stencil-nightly.yml
vendored
2
.github/workflows/stencil-nightly.yml
vendored
@ -46,6 +46,8 @@ jobs:
|
|||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v3
|
- uses: actions/checkout@v3
|
||||||
- uses: ./.github/workflows/actions/test-core-spec
|
- uses: ./.github/workflows/actions/test-core-spec
|
||||||
|
with:
|
||||||
|
stencil-version: nightly
|
||||||
|
|
||||||
test-core-screenshot:
|
test-core-screenshot:
|
||||||
strategy:
|
strategy:
|
||||||
|
Reference in New Issue
Block a user