javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 04:14:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(icon): update ionicons to flip for rtl (#17196)

Browse Source 
- updates to latest ionicons 4.55 and adds rtl test
- includes e2e test for RTL icons

references #17012
This commit is contained in:
Brandy Carney
2019-01-22 13:37:39 -05:00
committed by GitHub
parent 39c119ab4b
commit d3b6e60adf
9 changed files with 195 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/components/back-button/back-button.tsx
View File

@ -72,13 +72,9 @@ export class BackButton implements ComponentInterface {
render() {
const defaultBackButtonText = this.mode === 'ios' ? 'Back' : null;
const backButtonIcon = this.icon != null ? this.icon : this.config.get('backButtonIcon', 'arrow-back');
const backButtonText = this.text != null ? this.text : this.config.get('backButtonText', defaultBackButtonText);
let backButtonIcon = this.icon != null ? this.icon : this.config.get('backButtonIcon', 'arrow-back');
if (backButtonIcon === 'arrow-back' && document.dir === 'rtl') {
backButtonIcon = 'arrow-forward';
}
return (
<button
type="button"