javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-21 04:53:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(slides): remove the attributes from the slider and use options to pass them instead

Browse Source 
also commented out some attributes that aren’t working right now.

BREAKING CHANGES: Slider attributes have been removed in favor of
passing them in options

references #5189
This commit is contained in:
Brandy Carney
2016-02-18 12:17:40 -05:00
parent 8f0b88b7e4
commit d21ae88018
1 changed files with 4 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
ionic/components/slides/slides.ts
View File

@ -153,51 +153,30 @@ export class Slides extends Ion {
zoomableHeight: number zoomableHeight: number
} }
/**
* @input {boolean} whether or not the slides should automatically change
*/
@Input() autoplay: any;
/**
* @input {boolean} whether or not the slides should automatically change
*/
@Input() loop: any;
/**
* @input {number} The slide index to start on
*/
@Input() index: any;
/**
* @input {boolean} whether the slides should bounce
*/
@Input() bounce: any;
/** /**
* @input {boolean} Whether the slide should show the page or not * @input {boolean} Whether the slide should show the page or not
*/ */
@Input() pager: any; @Input() pager: any;
/** /**
* @input {any} Any additional slider options you want to pass * @input {any} Any slider options you want to configure, see swiper parameters: http://www.idangero.us/swiper/api/
*/ */
@Input() options: any; @Input() options: any;
/** /**
* @input {number} Whether or not the slider can zoom in or out * @input {number} Whether or not the slider can zoom in or out
*/ */
@Input() zoom: any; // @Input() zoom: any;
/** /**
* @input {number} how long it should take to zoom a slide * @input {number} how long it should take to zoom a slide
*/ */
@Input() zoomDuration: any; // @Input() zoomDuration: any;
/** /**
* @input {number} the max scale an slide can be zoomed * @input {number} the max scale an slide can be zoomed
*/ */
@Input() zoomMax: any; // @Input() zoomMax: any;
/** /**
* @output {any} expression to evaluate when a slide has been changed * @output {any} expression to evaluate when a slide has been changed
@ -234,19 +213,9 @@ export class Slides extends Ion {
} }
this.showPager = isTrueProperty(this.pager); this.showPager = isTrueProperty(this.pager);
this.loop = isTrueProperty(this.loop);
if (typeof(this.index) != 'undefined') {
this.index = parseInt(this.index);
}
var options = defaults({ var options = defaults({
loop: this.loop,
initialSlide: this.index,
pagination: '.swiper-pagination', pagination: '.swiper-pagination',
paginationClickable: true,
lazyLoading: true,
preloadImages: false
}, this.options); }, this.options);
options.onTap = (swiper, e) => { options.onTap = (swiper, e) => {