test(many): migrate tests to toHaveScreenshot (#26899)

core/src/components/datetime/test/highlightedDates/datetime.e2e.ts

@@ -34,9 +34,7 @@ test.describe('datetime: highlightedDates', () => {
     });
 
     await page.waitForChanges();
-    expect(await datetime.screenshot()).toMatchSnapshot(
-      `datetime-highlightedDates-array-${page.getSnapshotSettings()}.png`
-    );
+    await expect(datetime).toHaveScreenshot(`datetime-highlightedDates-array-${page.getSnapshotSettings()}.png`);
   });
 
   test('should render highlights correctly when using a callback', async ({ page }) => {
@@ -74,9 +72,7 @@ test.describe('datetime: highlightedDates', () => {
     });
 
     await page.waitForChanges();
-    expect(await datetime.screenshot()).toMatchSnapshot(
-      `datetime-highlightedDates-callback-${page.getSnapshotSettings()}.png`
-    );
+    await expect(datetime).toHaveScreenshot(`datetime-highlightedDates-callback-${page.getSnapshotSettings()}.png`);
   });
 
   test('should render highlights correctly when only using one color or the other', async ({ page }) => {
@@ -96,8 +92,6 @@ test.describe('datetime: highlightedDates', () => {
     });
 
     await page.waitForChanges();
-    expect(await datetime.screenshot()).toMatchSnapshot(
-      `datetime-highlightedDates-single-color-${page.getSnapshotSettings()}.png`
-    );
+    await expect(datetime).toHaveScreenshot(`datetime-highlightedDates-single-color-${page.getSnapshotSettings()}.png`);
   });
 });

core/src/components/item-sliding/test/test.utils.ts

@@ -23,9 +23,7 @@ export const testSlidingItem = async (
   // opening animation takes longer than waitForChanges accounts for
   await page.waitForTimeout(500);
 
-  expect(await item.screenshot()).toMatchSnapshot(
-    `item-sliding-${screenshotNameSuffix}-${page.getSnapshotSettings()}.png`
-  );
+  await expect(item).toHaveScreenshot(`item-sliding-${screenshotNameSuffix}-${page.getSnapshotSettings()}.png`);
 
   await item.evaluate(async (el: HTMLIonItemSlidingElement) => {
     await el.close();

core/src/components/picker-column/test/test.utils.ts

@@ -15,9 +15,7 @@ export async function testPickerColumn(page: E2EPage, buttonSelector: string, de
 
   await page.waitForChanges();
 
-  expect(await page.screenshot()).toMatchSnapshot(
-    `picker-${description}-column-initial-${page.getSnapshotSettings()}.png`
-  );
+  await expect(page).toHaveScreenshot(`picker-${description}-column-initial-${page.getSnapshotSettings()}.png`);
 
   // TODO FW-3403
   /*