From d0847aabdb27bf76331e2c0947b4375b7b2b902d Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Fri, 9 Jun 2017 18:19:03 -0400 Subject: [PATCH] style(lint): enable default rule and ignore variables with parents --- .scss-lint.yml | 2 +- .scss-linters/default_rule.rb | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/.scss-lint.yml b/.scss-lint.yml index 66e519d65c..49282b348d 100644 --- a/.scss-lint.yml +++ b/.scss-lint.yml @@ -17,7 +17,7 @@ linters: enabled: false DefaultRule: - enabled: false + enabled: true DuplicateProperty: enabled: false diff --git a/.scss-linters/default_rule.rb b/.scss-linters/default_rule.rb index 61243be106..fe94455fa7 100644 --- a/.scss-linters/default_rule.rb +++ b/.scss-linters/default_rule.rb @@ -3,21 +3,15 @@ module SCSSLint class Linter::DefaultRule < Linter include LinterRegistry - def visit_each(node) - return true - end - def visit_function(node) return true end - def visit_mixin(node) - return true - end - def visit_variable(node) return if source_from_range(node.source_range).include?('!default') + return unless node_ancestor(node, 2).nil? + add_lint(node, '!default should be used') end end