javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(toolbar): rename the slots to match other component behavior

Browse Source 
`left` -> `start`
`right` -> `end`
`start` -> `secondary`
`end` -> `primary`
This commit is contained in:
Brandy Carney
2018-03-27 16:41:30 -04:00
parent 6fbd708ae0
commit ce5b47ef99
29 changed files with 129 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
core/src/components/button/test/toolbar/index.html
View File

@@ -25,7 +25,7 @@
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button>
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
@@ -33,7 +33,7 @@
<ion-icon slot="icon-only" name="search"></ion-icon>
</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button color="secondary">
<ion-icon slot="icon-only" name="more"></ion-icon>
</ion-button>
@@ -42,7 +42,7 @@
</ion-toolbar>
<ion-toolbar color="primary">
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button class="closeButton" fill="clear">
Close
</ion-button>
@@ -50,7 +50,7 @@
<ion-icon slot="icon-only" name="search"></ion-icon>
</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button color="secondary">
<ion-icon slot="icon-only" name="more"></ion-icon>
</ion-button>
@@ -59,7 +59,7 @@
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button>
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
@@ -67,7 +67,7 @@
<ion-icon slot="icon-only" name="search"></ion-icon>
</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button color="secondary">
<ion-icon slot="icon-only" name="more"></ion-icon>
</ion-button>
@@ -76,7 +76,7 @@
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button class="activated">
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
@@ -84,7 +84,7 @@
<ion-icon slot="icon-only" name="search"></ion-icon>
</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button color="secondary" class="activated">
<ion-icon slot="icon-only" name="more"></ion-icon>
</ion-button>
@@ -93,54 +93,54 @@
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button fill="solid">
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
<ion-button fill="solid">
<ion-icon name="contact" slot="start"></ion-icon>
<ion-icon name="contact" slot="secondary"></ion-icon>
Solid
</ion-button>
</ion-buttons>
<ion-title>Solid</ion-title>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button fill="solid" color="secondary">
Help
<ion-icon name="help-circle" slot="end"></ion-icon>
<ion-icon name="help-circle" slot="primary"></ion-icon>
</ion-button>
</ion-buttons>
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button fill="solid" class="activated">
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
<ion-button fill="solid" class="activated">
<ion-icon name="contact" slot="start"></ion-icon>
<ion-icon name="contact" slot="secondary"></ion-icon>
Solid
</ion-button>
</ion-buttons>
<ion-title>Solid Activated</ion-title>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button fill="solid" color="secondary" class="activated">
Help
<ion-icon name="help-circle" slot="end"></ion-icon>
<ion-icon name="help-circle" slot="primary"></ion-icon>
</ion-button>
</ion-buttons>
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button fill="outline">
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
<ion-button fill="outline">
<ion-icon name="star" slot="start"></ion-icon>
<ion-icon name="star" slot="secondary"></ion-icon>
Star
</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button color="secondary" fill="outline">
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
@@ -149,16 +149,16 @@
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button fill="outline" class="activated">
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
<ion-button fill="outline" class="activated">
<ion-icon name="star" slot="start"></ion-icon>
<ion-icon name="star" slot="secondary"></ion-icon>
Star
</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button color="secondary" fill="outline" class="activated">
<ion-icon slot="icon-only" name="contact"></ion-icon>
</ion-button>
@@ -167,28 +167,28 @@
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button>
<ion-icon name="contact" slot="start"></ion-icon>
<ion-icon name="contact" slot="secondary"></ion-icon>
Clear
</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button href="#">
Edit
<ion-icon name="create" slot="end"></ion-icon>
<ion-icon name="create" slot="primary"></ion-icon>
</ion-button>
</ion-buttons>
<ion-title>Icon/Color Attr</ion-title>
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button>
Go Back
</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button href="#">
Edit
</ion-button>
@@ -197,10 +197,10 @@
</ion-toolbar>
<ion-toolbar>
<ion-button menuToggle slot="start">
<ion-button menuToggle slot="secondary">
<ion-icon name="menu"></ion-icon>
</ion-button>
<ion-buttons slot="start">
<ion-buttons slot="secondary">
<ion-button>
<ion-icon slot="icon-only" name="star"></ion-icon>
</ion-button>
@@ -209,19 +209,19 @@
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button>
<ion-icon slot="icon-only" name="star"></ion-icon>
</ion-button>
</ion-buttons>
<ion-title>Right side menu toggle</ion-title>
<ion-button menuToggle slot="end">
<ion-button menuToggle slot="primary">
<ion-icon name="menu"></ion-icon>
</ion-button>
</ion-toolbar>
<ion-toolbar>
<ion-buttons slot="end">
<ion-buttons slot="primary">
<ion-button>
<ion-icon slot="icon-only" name="search"></ion-icon>
</ion-button>