From ce0bed4cf3ad6574346621cb98e488d7ec29bccb Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Mon, 14 Oct 2019 14:00:18 -0400 Subject: [PATCH] chore(release): update release script to move the npm link --- .scripts/common.js | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/.scripts/common.js b/.scripts/common.js index 7e07d80d2a..09240d0d5f 100644 --- a/.scripts/common.js +++ b/.scripts/common.js @@ -156,13 +156,6 @@ function preparePackage(tasks, package, version, install) { title: `${pkg.name}: lint`, task: () => execa('npm', ['run', 'lint'], { cwd: projectRoot }) }); - projectTasks.push({ - title: `${pkg.name}: update ionic/core dep to ${version}`, - task: () => { - updateDependency(pkg, '@ionic/core', version); - writePkg(package, pkg); - } - }); projectTasks.push({ title: `${pkg.name}: test`, task: () => execa('npm', ['test'], { cwd: projectRoot }) @@ -179,6 +172,16 @@ function preparePackage(tasks, package, version, install) { task: () => execa('npm', ['link'], { cwd: projectRoot }) }); } + + if (version) { + projectTasks.push({ + title: `${pkg.name}: update ionic/core dep to ${version}`, + task: () => { + updateDependency(pkg, '@ionic/core', version); + writePkg(package, pkg); + } + }); + } } // Add project tasks @@ -215,7 +218,7 @@ function prepareDevPackage(tasks, package, version) { task: () => execa('npm', ['run', 'build'], { cwd: projectRoot }) }); - if (package === 'core') { + if (package === 'core' || package === 'packages/react') { projectTasks.push({ title: `${pkg.name}: npm link`, task: () => execa('npm', ['link'], { cwd: projectRoot })