javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 03:32:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(NavRouter): rename navigateInstruction to navigateByInstruction

Browse Source
This commit is contained in:
Tim Lancina
2015-10-22 12:57:19 -05:00
parent 7b13051a52
commit cb49adcb0c
1 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
ionic/components/nav/nav-router.ts
View File

@ -74,22 +74,21 @@ export class NavRouter extends RouterOutlet {
// viewCtrl is Ionic's ViewController class, which has the properties "componentType" and "params" // viewCtrl is Ionic's ViewController class, which has the properties "componentType" and "params"
// only do an update if there's an actual view change // only do an update if there's an actual view change
// if (!viewCtrl || this._activeViewId === viewCtrl.id) return; if (!viewCtrl || this._activeViewId === viewCtrl.id) return;
// this._activeViewId = viewCtrl.id; this._activeViewId = viewCtrl.id;
// // get the best PathRecognizer for this view's componentType // get the best PathRecognizer for this view's componentType
// let pathRecognizer = this.getPathRecognizerByComponent(viewCtrl.componentType); let pathRecognizer = this.getPathRecognizerByComponent(viewCtrl.componentType);
// if (pathRecognizer) { if (pathRecognizer) {
// // generate a componentInstruction from the view's PathRecognizer and params // generate a componentInstruction from the view's PathRecognizer and params
// let componentInstruction = pathRecognizer.generate(viewCtrl.params.data); let componentInstruction = pathRecognizer.generate(viewCtrl.params.data);
// // create an Instruction from the componentInstruction // create an Instruction from the componentInstruction
// let instruction = new Instruction(componentInstruction, null); let instruction = new Instruction(componentInstruction, null);
// // update the browser's URL this._parentRouter.navigateByInstruction(instruction);
// this._parentRouter.navigateInstruction(instruction); }
// }
} }
/** /**