javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 18:17:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(vue): unmount teleported user component (#26543)

Browse Source 
Resolves #26542
This commit is contained in:
Sean Perkins
2023-01-04 17:33:45 -05:00
committed by GitHub
parent 3e671b9c8f
commit c996384786
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/vue/src/components/IonApp.ts
View File

@ -33,5 +33,14 @@ export const addTeleportedUserComponent = (component: VNode) => {
}
export const removeTeleportedUserComponent = (component: VNode) => {
userComponents.value = userComponents.value.filter(cmp => cmp !== component);
/**
* Finds the index of the component in the array and removes it.
* Previously we were using a filter to remove the component from the array,
* but this was causing a bug where dismissing an overlay and then presenting
* a new overlay, would cause the new overlay to be removed.
*/
const index = userComponents.value.findIndex(cmp => cmp === component);
if (index !== -1) {
userComponents.value.splice(index, 1);
}
}