javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(e2e): add --dev option to e2e.prod to speed up builds for faster but less thorough verification

Browse Source
This commit is contained in:
Dan Bucholtz
2017-03-09 12:13:36 -06:00
parent a7ea189fa3
commit c90fcb07e7
4 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
scripts/gulp/utils/app-scripts-worker-client.ts
View File

@ -3,7 +3,7 @@ import { join } from 'path';
import { MessageToWorker, WorkerProcess } from './interfaces';
export function runWorker(pathToAppScripts: string, debug: boolean, appEntryPoint: string, appNgModulePath: string, srcDir: string, distDir: string, tsConfig: string, ionicAngularDir: string, sassConfigPath: string, copyConfigPath: string) {
export function runWorker(pathToAppScripts: string, debug: boolean, appEntryPoint: string, appNgModulePath: string, srcDir: string, distDir: string, tsConfig: string, ionicAngularDir: string, sassConfigPath: string, copyConfigPath: string, isDev: boolean) {
return new Promise((resolve, reject) => {
const msgToWorker: MessageToWorker = {
@ -16,11 +16,13 @@ export function runWorker(pathToAppScripts: string, debug: boolean, appEntryPoin
tsConfig: tsConfig,
ionicAngularDir: ionicAngularDir,
sassConfigPath: sassConfigPath,
copyConfigPath: copyConfigPath
copyConfigPath: copyConfigPath,
isDev: isDev
};
const worker = <ChildProcess>createWorker(msgToWorker);
console.log(`Starting to build test ${appEntryPoint}`);
console.log(`Starting to do a ${isDev ? 'dev' : 'prod'} build test ${appEntryPoint}`);
worker.on('error', (err: any) => {
console.error(`worker error, entrypoint: ${appEntryPoint}, pid: ${worker.pid}, error: ${err}`);
@ -56,8 +58,6 @@ export function createWorker(msg: MessageToWorker): any {
try {
let scriptArgs = [
'build',
'--aot',
'--optimizejs',
'--appEntryPoint', msg.appEntryPoint,
'--appNgModulePath', msg.appNgModulePath,
'--srcDir', msg.srcDir,
@ -71,9 +71,13 @@ export function createWorker(msg: MessageToWorker): any {
'--sass', msg.sassConfigPath,
'--copy', msg.copyConfigPath,
'--enableLint', 'false',
// '--disableLogging', 'true'
];
// TODO, use prod once we're a little more settled
if (!msg.isDev) {
scriptArgs.push('--aot');
}
if (msg.debug) {
scriptArgs.push('--debug');
}