From c8d214a82c7cda0fc66518021cec8162804fea1a Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 31 Aug 2023 12:45:06 -0400 Subject: [PATCH] chore(vue): add missing routerAnimation type (#28094) Issue number: N/A --------- ## What is the current behavior? The Vue Router implementation [assigns data to the `routerAnimation` on the view item](https://github.com/ionic-team/ionic-framework/blob/cddefd1548be1f43fd529483e3829d3f5719a753/packages/vue/src/components/IonRouterOutlet.ts#L165-L170), but the [type does not exist on the `ViewItem` interface](https://github.com/ionic-team/ionic-framework/blob/main/packages/vue-router/src/types.ts#L62-L76). The actual routing implementation does not make use of the type, but this is backfilling the information when we wire up the types to the implementation. ## What is the new behavior? - Adds the missing type for `routerAnimation` to the `ViewItem` ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --- packages/vue-router/src/types.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/vue-router/src/types.ts b/packages/vue-router/src/types.ts index 8cccdaa468..e1cddbfde5 100644 --- a/packages/vue-router/src/types.ts +++ b/packages/vue-router/src/types.ts @@ -73,6 +73,7 @@ export interface ViewItem { vueComponentRef: Ref; params?: { [k: string]: any }; vueComponentData: VueComponentData; + routerAnimation?: AnimationBuilder; } export interface ViewStacks {