javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 10:41:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): prevent errors when dismissing inline popover after containing element is removed (#24569)

Browse Source
This commit is contained in:
Amanda Smith
2022-01-12 14:51:50 -06:00
committed by GitHub
parent 273ae2cc08
commit c8a392aef5
3 changed files with 28 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/react/src/components/createInlineOverlayComponent.tsx
View File

@ -78,10 +78,19 @@ export const createInlineOverlayComponent = <PropType, ElementType>(
* cleanup properly.
*/
this.ref.current?.addEventListener('didDismiss', (evt: any) => {
const wrapper = this.wrapperRef.current!;
this.ref.current!.append(wrapper);
const wrapper = this.wrapperRef.current;
const el = this.ref.current;
this.setState({ isOpen: false });
/**
* This component might be unmounted already, if the containing
* element was removed while the popover was still open. (For
* example, if an item contains an inline popover with a button
* that removes the item.)
*/
if (wrapper && el) {
el.append(wrapper);
this.setState({ isOpen: false });
}
this.props.onDidDismiss && this.props.onDidDismiss(evt);
});