javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unused sass variables (#28363)

Browse Source 
Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

This project has several unused Sass variables still in the code base.
The team would like to remove these.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removed unused Sass variables


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

The original scope of this ticket was for checkbox only, but many other
components had unused sass variables, so I decided to tackle everything
all at once.

Since these variables are not used anywhere:

1. The build should pass
2. There should be no screenshot diffs
This commit is contained in:
Liam DeBeasi
2023-10-19 12:41:10 -04:00
committed by GitHub
parent 5a30082546
commit c801e2ada9
51 changed files with 3 additions and 600 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/components/toggle/toggle.ios.vars.scss
View File

@ -19,9 +19,6 @@ $toggle-ios-border-radius: $toggle-ios-height * 0.5 !default;
/// @prop - Background color of the unchecked toggle
$toggle-ios-background-color-off: rgba($text-color-rgb, .088) !default;
/// @prop - Background color of the checked toggle
$toggle-ios-background-color-on: ion-color(primary, base) !default;
/// @prop - Width of the toggle handle
$toggle-ios-handle-width: calc(#{$toggle-ios-height} - (#{$toggle-ios-border-width} * 2)) !default;

9
core/src/components/toggle/toggle.md.vars.scss
View File

@ -4,9 +4,6 @@
// Material Design Toggle
// --------------------------------------------------
/// @prop - Color of the active toggle
$toggle-md-active-color: ion-color(primary, base) !default;
/// @prop - Width of the toggle track
$toggle-md-track-width: 36px !default;
@ -19,9 +16,6 @@ $toggle-md-track-background-color-off: rgba(var(--ion-text-color-rgb,
/// @prop - Background color alpha of the checked toggle track
$toggle-md-track-background-color-alpha-on: .5 !default;
/// @prop - Background color of the checked toggle track
$toggle-md-track-background-color-on: ion-color(primary, base, $toggle-md-track-background-color-alpha-on) !default;
/// @prop - Width of the toggle handle
$toggle-md-handle-width: 20px !default;
@ -40,9 +34,6 @@ $toggle-md-handle-box-shadow: 0 3px 1px -2px rgba(0, 0, 0, .
/// @prop - Background color of the toggle handle
$toggle-md-handle-background-color-off: #ffffff !default;
/// @prop - Background color of the checked toggle handle
$toggle-md-handle-background-color-on: $toggle-md-active-color !default;
/// @prop - Margin top of the toggle
$toggle-md-media-margin-top: 0 !default;