javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unused sass variables (#28363)

Browse Source 
Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

This project has several unused Sass variables still in the code base.
The team would like to remove these.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removed unused Sass variables


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

The original scope of this ticket was for checkbox only, but many other
components had unused sass variables, so I decided to tackle everything
all at once.

Since these variables are not used anywhere:

1. The build should pass
2. There should be no screenshot diffs
This commit is contained in:
Liam DeBeasi
2023-10-19 12:41:10 -04:00
committed by GitHub
parent 5a30082546
commit c801e2ada9
51 changed files with 3 additions and 600 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/components/textarea/textarea.ios.vars.scss
View File

@ -4,9 +4,6 @@
// iOS Textarea
// --------------------------------------------------
/// @prop - Margin start of the textarea when it is after a label
$textarea-ios-by-label-margin-start: $item-ios-padding-start !default;
/// @prop - Font size of the textarea
$textarea-ios-font-size: inherit !default;
@ -22,8 +19,5 @@ $textarea-ios-padding-bottom: $item-ios-padding-bottom !default;
/// @prop - Margin start of the textarea
$textarea-ios-padding-start: 0 !default;
/// @prop - Placeholder text color of the textarea
$textarea-ios-placeholder-color: $placeholder-text-color !default;
/// @prop - The opacity of the input text, label, helper text, char counter and placeholder of a disabled textarea
$textarea-ios-disabled-opacity: $form-control-ios-disabled-opacity !default;

3
core/src/components/textarea/textarea.md.vars.scss
View File

@ -19,9 +19,6 @@ $textarea-md-padding-bottom: $item-md-padding-bottom !default;
/// @prop - Margin start of the textarea
$textarea-md-padding-start: ($item-md-padding-start * 0.5) !default;
/// @prop - Placeholder text color of the textarea
$textarea-md-placeholder-color: $placeholder-text-color !default;
/// @prop - The amount of whitespace to display on either side of the floating label
$textarea-md-floating-label-padding: 4px !default;