javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-07 23:16:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unused sass variables (#28363)

Browse Source 
Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

This project has several unused Sass variables still in the code base.
The team would like to remove these.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removed unused Sass variables


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

The original scope of this ticket was for checkbox only, but many other
components had unused sass variables, so I decided to tackle everything
all at once.

Since these variables are not used anywhere:

1. The build should pass
2. There should be no screenshot diffs
This commit is contained in:
Liam DeBeasi
2023-10-19 12:41:10 -04:00
committed by GitHub
parent 5a30082546
commit c801e2ada9
51 changed files with 3 additions and 600 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/src/components/label/label.ios.vars.scss
View File

@ -4,24 +4,9 @@
// iOS Label
// --------------------------------------------------
/// @prop - Text color of the label by an input, select, or datetime
$label-ios-text-color: null !default;
/// @prop - Text color of the stacked/floating label when it is focused
$label-ios-text-color-focused: null !default;
/// @prop - Margin top of the label
$label-ios-margin-top: $item-ios-padding-top !default;
/// @prop - Margin end of the label
$label-ios-margin-end: ($item-ios-padding-end * 0.5) !default;
/// @prop - Margin bottom of the label
$label-ios-margin-bottom: $item-ios-padding-bottom !default;
/// @prop - Margin start of the label
$label-ios-margin-start: 0 !default;
/// @prop - Font size of the label when the text wraps
$label-ios-text-wrap-font-size: dynamic-font(14px) !default;

3
core/src/components/label/label.md.vars.scss
View File

@ -4,9 +4,6 @@
// Material Design Label
// --------------------------------------------------
/// @prop - Text color of the label by an input, select, or datetime
$label-md-text-color: $text-color-step-600 !default;
/// @prop - Text color of the stacked/floating label when it is focused
$label-md-text-color-focused: ion-color(primary, base) !default;