javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unused sass variables (#28363)

Browse Source 
Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

This project has several unused Sass variables still in the code base.
The team would like to remove these.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removed unused Sass variables


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

The original scope of this ticket was for checkbox only, but many other
components had unused sass variables, so I decided to tackle everything
all at once.

Since these variables are not used anywhere:

1. The build should pass
2. There should be no screenshot diffs
This commit is contained in:
Liam DeBeasi
2023-10-19 12:41:10 -04:00
committed by GitHub
parent 5a30082546
commit c801e2ada9
51 changed files with 3 additions and 600 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/components/item/item.ios.vars.scss
View File

@ -36,9 +36,6 @@ $item-ios-avatar-height: $item-ios-avatar-width !default;
/// @prop - Size of the thumbnail in the item
$item-ios-thumbnail-size: 56px !default;
/// @prop - Color of the detail arrow icon
$item-ios-detail-icon-color: $item-ios-border-color !default;
/// @prop - Padding top for the item content
$item-ios-padding-top: 10px !default;
@ -60,9 +57,6 @@ $item-ios-border-bottom-style: solid !default;
/// @prop - Border bottom color for the item when lines are displayed
$item-ios-border-bottom-color: $item-ios-border-color !default;
/// @prop - Border bottom for the item
$item-ios-border-bottom: $item-ios-border-bottom-width $item-ios-border-bottom-style $item-ios-border-bottom-color !default;
/// @prop - Color of the item input highlight
$item-ios-input-highlight-color: ion-color(primary, base) !default;

9
core/src/components/item/item.md.vars.scss
View File

@ -21,9 +21,6 @@ $item-md-avatar-height: $item-md-avatar-width !default;
/// @prop - Size of the thumbnail in the item
$item-md-thumbnail-size: 56px !default;
/// @prop - Color of the detail arrow icon
$item-md-detail-icon-color: $item-md-border-color !default;
/// @prop - Padding top for the item content
$item-md-padding-top: 10px !default;
@ -45,9 +42,6 @@ $item-md-border-bottom-style: solid !default;
/// @prop - Border bottom color for the item when lines are displayed
$item-md-border-bottom-color: $item-md-border-color !default;
/// @prop - Border bottom for the item when lines are displayed
$item-md-border-bottom: $item-md-border-bottom-width $item-md-border-bottom-style $item-md-border-color !default;
// Item Input
// --------------------------------------------------
@ -75,9 +69,6 @@ $item-md-input-fill-border-color: $background-color-step-500 !default;
/// @prop - Color of the item border when `fill` is set and hovered
$item-md-input-fill-border-color-hover: $background-color-step-750 !default;
/// @prop - Color of the item input counter
$item-md-input-counter-color: rgba(0, 0, 0, .6) !default;
/// @prop - Letter spacing of the item input counter
$item-md-input-counter-letter-spacing: .0333333333em !default;