From c7b302c7a624f6f6e0977c115d4edd91f442345a Mon Sep 17 00:00:00 2001 From: Manu MA Date: Fri, 30 Aug 2019 20:20:55 +0200 Subject: [PATCH] refactor(): add scss usage deprecation warning (#19238) --- core/src/themes/ionic.deprecation.scss | 5 +++++ core/src/themes/ionic.functions.color.scss | 2 ++ core/src/themes/ionic.functions.string.scss | 1 + core/src/themes/ionic.mixins.scss | 1 + core/src/themes/ionic.skip-warns.scss | 1 + core/src/themes/ionic.theme.default.scss | 2 ++ core/stencil.config.ts | 4 +++- 7 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 core/src/themes/ionic.deprecation.scss create mode 100644 core/src/themes/ionic.skip-warns.scss diff --git a/core/src/themes/ionic.deprecation.scss b/core/src/themes/ionic.deprecation.scss new file mode 100644 index 0000000000..3d6a7aba42 --- /dev/null +++ b/core/src/themes/ionic.deprecation.scss @@ -0,0 +1,5 @@ +$IONIC: false !default; + +@if not $IONIC { + @warn "[DEPRECATED] SCSS within ionic/core should not be imported. Next major release will remove all scss support."; +} diff --git a/core/src/themes/ionic.functions.color.scss b/core/src/themes/ionic.functions.color.scss index 1d78bbe131..d82572d5bc 100644 --- a/core/src/themes/ionic.functions.color.scss +++ b/core/src/themes/ionic.functions.color.scss @@ -1,3 +1,5 @@ +@import "./ionic.deprecation"; + // Gets the active color's css variable from a variation. Alpha is optional. // -------------------------------------------------------------------------------------------- // Example usage: diff --git a/core/src/themes/ionic.functions.string.scss b/core/src/themes/ionic.functions.string.scss index 8f1eaef5e7..e3637816a3 100644 --- a/core/src/themes/ionic.functions.string.scss +++ b/core/src/themes/ionic.functions.string.scss @@ -1,3 +1,4 @@ +@import "./ionic.deprecation"; // String Utility Functions // -------------------------------------------------------------------------------- diff --git a/core/src/themes/ionic.mixins.scss b/core/src/themes/ionic.mixins.scss index 6e89e8d295..6fe25be231 100644 --- a/core/src/themes/ionic.mixins.scss +++ b/core/src/themes/ionic.mixins.scss @@ -1,3 +1,4 @@ +@import "./ionic.deprecation"; @mixin input-cover() { @include position(0, null, null, 0); diff --git a/core/src/themes/ionic.skip-warns.scss b/core/src/themes/ionic.skip-warns.scss new file mode 100644 index 0000000000..921384c5c3 --- /dev/null +++ b/core/src/themes/ionic.skip-warns.scss @@ -0,0 +1 @@ +$IONIC: true; diff --git a/core/src/themes/ionic.theme.default.scss b/core/src/themes/ionic.theme.default.scss index 0e68c133e5..b4ddb24685 100644 --- a/core/src/themes/ionic.theme.default.scss +++ b/core/src/themes/ionic.theme.default.scss @@ -1,3 +1,5 @@ +@import "./ionic.deprecation"; + // Ionic Theme // ------------------------------------------------------------------------------------------- // This file contains the theme variables shared diff --git a/core/stencil.config.ts b/core/stencil.config.ts index 8ecffa57c2..d926aa87fa 100644 --- a/core/stencil.config.ts +++ b/core/stencil.config.ts @@ -64,7 +64,9 @@ export const config: Config = { ]}, ], plugins: [ - sass() + sass({ + injectGlobalPaths: ['src/themes/ionic.skip-warns.scss'] + }) ], outputTargets: [ {