From c65734dd40f1fbbf4aa6008c9bc313ec92cd08c7 Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Thu, 13 Dec 2018 16:53:06 +0100 Subject: [PATCH] chore(): lint before update package.json --- .scripts/common.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.scripts/common.js b/.scripts/common.js index 98da1acc09..86a64be767 100644 --- a/.scripts/common.js +++ b/.scripts/common.js @@ -93,15 +93,6 @@ function preparePackage(tasks, package, version) { title: `${pkg.name}: npm link @ionic/core`, task: () => execa('npm', ['link', '@ionic/core'], { cwd: projectRoot }) }); - if (version) { - projectTasks.push({ - title: `${pkg.name}: update ionic/core dep to ${version}`, - task: () => { - updateDependency(pkg, "@ionic/core", version); - writePkg(package, pkg); - } - }); - } } if (version) { @@ -109,6 +100,13 @@ function preparePackage(tasks, package, version) { title: `${pkg.name}: lint`, task: () => execa('npm', ['run', 'lint'], { cwd: projectRoot }) }); + projectTasks.push({ + title: `${pkg.name}: update ionic/core dep to ${version}`, + task: () => { + updateDependency(pkg, "@ionic/core", version); + writePkg(package, pkg); + } + }); projectTasks.push({ title: `${pkg.name}: test`, task: () => execa('npm', ['test'], { cwd: projectRoot }) @@ -119,10 +117,12 @@ function preparePackage(tasks, package, version) { title: `${pkg.name}: build`, task: () => execa('npm', ['run', 'build'], { cwd: projectRoot }) }); - projectTasks.push({ - title: `${pkg.name}: npm link`, - task: () => execa('npm', ['link'], { cwd: projectRoot }) - }); + if (package === 'core') { + projectTasks.push({ + title: `${pkg.name}: npm link`, + task: () => execa('npm', ['link'], { cwd: projectRoot }) + }); + } } // Add project tasks