From c6127e91f0d068a81773a89df1816ce7277ddfcd Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 23 Apr 2024 16:01:12 -0400 Subject: [PATCH] chore(input): lint styles and add TODO for future work --- core/src/components/input/input.ionic.outline.scss | 5 ++--- core/src/components/input/input.ionic.scss | 2 +- core/src/components/input/input.ionic.vars.scss | 1 - core/src/components/input/input.tsx | 1 + 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/core/src/components/input/input.ionic.outline.scss b/core/src/components/input/input.ionic.outline.scss index 609b285252..4528a6d1ad 100644 --- a/core/src/components/input/input.ionic.outline.scss +++ b/core/src/components/input/input.ionic.outline.scss @@ -80,7 +80,6 @@ min-height: 40px; } - // Input Fill: Outline, Outline Container // ---------------------------------------------------------------- @@ -98,7 +97,6 @@ border: var(--border-width) var(--border-style) var(--border-color); } - // Input Fill: Outline, Label Placement: Stacked // ---------------------------------------------------------------- @@ -136,7 +134,8 @@ :host(.input-fill-outline.input-disabled) .native-wrapper { --background: #{$ionic-color-neutral-10}; - border-radius: inherit; + + @include border-radius(inherit); background: var(--background); } diff --git a/core/src/components/input/input.ionic.scss b/core/src/components/input/input.ionic.scss index 2c031328fa..c5b50ad094 100644 --- a/core/src/components/input/input.ionic.scss +++ b/core/src/components/input/input.ionic.scss @@ -34,7 +34,7 @@ } .input-clear-icon.ion-focused { - border-radius: #{$ionic-border-radius-rounded-small}; + @include border-radius($ionic-border-radius-rounded-small); outline: #{$ionic-border-size-medium} solid #{$ionic-color-primary-100}; diff --git a/core/src/components/input/input.ionic.vars.scss b/core/src/components/input/input.ionic.vars.scss index 5b8e433a8f..7772c81e40 100644 --- a/core/src/components/input/input.ionic.vars.scss +++ b/core/src/components/input/input.ionic.vars.scss @@ -1,3 +1,2 @@ - // Ionic Input // -------------------------------------------------- diff --git a/core/src/components/input/input.tsx b/core/src/components/input/input.tsx index b6263e30ae..f1db342377 100644 --- a/core/src/components/input/input.tsx +++ b/core/src/components/input/input.tsx @@ -499,6 +499,7 @@ export class Input implements ComponentInterface { return labelPlacement; } + // TODO(FW-6201): Remove this method when size is supported in ios and md private getSize() { const theme = getIonTheme(this); const { size } = this;