javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 04:14:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(animation): enable backwards compatibility for overlay animations (#19160)

Browse Source 
* fix backwards compat for overlays

* fix overlay

* Address navigation edge case
This commit is contained in:
Liam DeBeasi
2019-08-23 10:56:05 -04:00
committed by GitHub
parent 50a92c026c
commit c610406ba6
3 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/src/utils/overlays.ts
View File

@ -190,11 +190,15 @@ const overlayAnimation = async (
/**
* TODO: Remove AnimationBuilder
*/
const animation = await import('./animation/old-animation').then(mod => mod.create(animationBuilder as AnimationBuilder, aniRoot, opts));
const isAnimationBuilder = (animation as any).fill === undefined;
if (!isAnimationBuilder) {
(animation as any).fill('both');
let animation;
let isAnimationBuilder = true;
try {
const mod = await import('./animation/old-animation');
animation = await mod.create(animationBuilder as AnimationBuilder, aniRoot, opts);
} catch (err) {
animation = (animationBuilder as IonicAnimationInterface)(aniRoot, opts);
animation.fill('both');
isAnimationBuilder = false;
}
overlay.animation = animation;