javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 10:41:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(overlays): esc button works closed top overlays

Browse Source 
fixes #14662
This commit is contained in:
Manu Mtz.-Almeida
2018-08-21 17:58:49 +02:00
parent d83e7f8840
commit c567a82bfc
9 changed files with 80 additions and 179 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
core/src/components/popover-controller/popover-controller.tsx
View File

@ -1,33 +1,15 @@
import { Component, Listen, Method, Prop } from '@stencil/core';
import { Component, Method, Prop } from '@stencil/core';
import { OverlayController, PopoverOptions } from '../../interface';
import { createOverlay, dismissOverlay, getTopOverlay, removeLastOverlay } from '../../utils/overlays';
import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays';
@Component({
tag: 'ion-popover-controller'
})
export class PopoverController implements OverlayController {
private popovers = new Map<number, HTMLIonPopoverElement>();
@Prop({ context: 'document' }) doc!: Document;
@Listen('body:ionPopoverWillPresent')
protected popoverWillPresent(ev: any) {
this.popovers.set(ev.target.overlayId, ev.target);
}
@Listen('body:ionPopoverWillDismiss')
@Listen('body:ionPopoverDidUnload')
protected popoverWillDismiss(ev: any) {
this.popovers.delete(ev.target.overlayId);
}
@Listen('body:keyup.escape')
protected escapeKeyUp() {
removeLastOverlay(this.popovers);
}
/**
* Create a popover overlay with popover options.
*/
@ -41,7 +23,7 @@ export class PopoverController implements OverlayController {
*/
@Method()
dismiss(data?: any, role?: string, popoverId = -1) {
return dismissOverlay(data, role, this.popovers, popoverId);
return dismissOverlay(this.doc, data, role, 'ion-popover', popoverId);
}
/**
@ -49,6 +31,6 @@ export class PopoverController implements OverlayController {
*/
@Method()
getTop(): HTMLIonPopoverElement {
return getTopOverlay(this.popovers);
return getOverlay(this.doc, 'ion-popover') as HTMLIonPopoverElement;
}
}