From c50c43a5a9aab03776e965f9734942bf53765e4f Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 3 May 2023 20:05:42 -0400 Subject: [PATCH] test(title): migrate to generators (#27382) Issue number: N/A --------- ## What is the current behavior? Title tests are using legacy syntax ## What is the new behavior? - Title tests are using modern syntax ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --- .../title/test/basic/title.e2e-legacy.ts | 12 ------------ core/src/components/title/test/basic/title.e2e.ts | 14 ++++++++++++++ .../title-basic-ios-ltr-Mobile-Chrome-linux.png | Bin .../title-basic-ios-ltr-Mobile-Firefox-linux.png | Bin .../title-basic-ios-ltr-Mobile-Safari-linux.png | Bin .../title-basic-ios-rtl-Mobile-Chrome-linux.png | Bin .../title-basic-ios-rtl-Mobile-Firefox-linux.png | Bin .../title-basic-ios-rtl-Mobile-Safari-linux.png | Bin .../title-basic-md-ltr-Mobile-Chrome-linux.png | Bin .../title-basic-md-ltr-Mobile-Firefox-linux.png | Bin .../title-basic-md-ltr-Mobile-Safari-linux.png | Bin .../title-basic-md-rtl-Mobile-Chrome-linux.png | Bin .../title-basic-md-rtl-Mobile-Firefox-linux.png | Bin .../title-basic-md-rtl-Mobile-Safari-linux.png | Bin 14 files changed, 14 insertions(+), 12 deletions(-) delete mode 100644 core/src/components/title/test/basic/title.e2e-legacy.ts create mode 100644 core/src/components/title/test/basic/title.e2e.ts rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-ios-ltr-Mobile-Chrome-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-ios-ltr-Mobile-Firefox-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-ios-ltr-Mobile-Safari-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-ios-rtl-Mobile-Chrome-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-ios-rtl-Mobile-Firefox-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-ios-rtl-Mobile-Safari-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-md-ltr-Mobile-Chrome-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-md-ltr-Mobile-Firefox-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-md-ltr-Mobile-Safari-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-md-rtl-Mobile-Chrome-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-md-rtl-Mobile-Firefox-linux.png (100%) rename core/src/components/title/test/basic/{title.e2e-legacy.ts-snapshots => title.e2e.ts-snapshots}/title-basic-md-rtl-Mobile-Safari-linux.png (100%) diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts b/core/src/components/title/test/basic/title.e2e-legacy.ts deleted file mode 100644 index 83444e2a54..0000000000 --- a/core/src/components/title/test/basic/title.e2e-legacy.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { expect } from '@playwright/test'; -import { test } from '@utils/test/playwright'; - -test.describe('title: basic', () => { - test('should not have visual regressions', async ({ page }) => { - await page.goto('/src/components/title/test/basic'); - const wrapper = page.locator('#header-wrapper'); - - // only screenshot the headers to avoid unnecessary blank space from ion-content - await expect(wrapper).toHaveScreenshot(`title-basic-${page.getSnapshotSettings()}.png`); - }); -}); diff --git a/core/src/components/title/test/basic/title.e2e.ts b/core/src/components/title/test/basic/title.e2e.ts new file mode 100644 index 0000000000..a821bcf9b7 --- /dev/null +++ b/core/src/components/title/test/basic/title.e2e.ts @@ -0,0 +1,14 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +configs().forEach(({ title, screenshot, config }) => { + test.describe(title('title: basic'), () => { + test('should not have visual regressions', async ({ page }) => { + await page.goto('/src/components/title/test/basic', config); + const wrapper = page.locator('#header-wrapper'); + + // only screenshot the headers to avoid unnecessary blank space from ion-content + await expect(wrapper).toHaveScreenshot(screenshot(`title-basic`)); + }); + }); +}); diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-ltr-Mobile-Chrome-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-ltr-Mobile-Firefox-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-ltr-Mobile-Safari-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-ltr-Mobile-Safari-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-rtl-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-rtl-Mobile-Chrome-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-rtl-Mobile-Chrome-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-rtl-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-rtl-Mobile-Firefox-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-rtl-Mobile-Firefox-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-rtl-Mobile-Safari-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-rtl-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-ios-rtl-Mobile-Safari-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-rtl-Mobile-Safari-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-ltr-Mobile-Chrome-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-ltr-Mobile-Firefox-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-ltr-Mobile-Safari-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-ltr-Mobile-Safari-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-rtl-Mobile-Chrome-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-rtl-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-rtl-Mobile-Chrome-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-rtl-Mobile-Chrome-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-rtl-Mobile-Firefox-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-rtl-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-rtl-Mobile-Firefox-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-rtl-Mobile-Firefox-linux.png diff --git a/core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-rtl-Mobile-Safari-linux.png b/core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-rtl-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/title/test/basic/title.e2e-legacy.ts-snapshots/title-basic-md-rtl-Mobile-Safari-linux.png rename to core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-md-rtl-Mobile-Safari-linux.png