fix(checkbox): click events on ion-item now fire properly (#22561)

resolves #22557
This commit is contained in:
Liam DeBeasi
2020-11-24 14:31:24 -05:00
committed by GitHub
parent afcc46e1cc
commit c45c8d5564

View File

@ -114,10 +114,7 @@ export class Checkbox implements ComponentInterface {
}
}
private onClick = (ev: Event) => {
ev.preventDefault();
ev.stopPropagation();
private onClick = () => {
this.setFocus();
this.checked = !this.checked;
this.indeterminate = false;
@ -171,6 +168,14 @@ export class Checkbox implements ComponentInterface {
{labelText}
</label>
<input
onClick={(ev: Event) => {
{/**
* This is needed otherwise any click
* events set on `ion-item` are fired twice
*/}
ev.preventDefault();
ev.stopPropagation()
}}
type="checkbox"
aria-checked={`${checked}`}
disabled={disabled}