javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(hide-when): mode is a reserved property

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-08-26 22:29:46 +02:00
parent 86acb8cd92
commit c446d1b6d1
7 changed files with 87 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/components/hide-when/hide-when.tsx
View File

@ -1,7 +1,7 @@
import { Component, Element, Listen, Prop, State } from '@stencil/core';
import { Config, Mode } from '../../interface';
import { DisplayWhen, updateTestResults } from '../../utils/show-hide-when-utils';
import { Config } from '../../interface';
import { DisplayWhen, getTestResult } from '../../utils/show-hide-when-utils';
@Component({
tag: 'ion-hide-when',
@ -17,7 +17,7 @@ export class HideWhen implements DisplayWhen {
* If the current platform matches the given value, the element will hide.
* Accepts a comma separated list of modes to match against.
*/
@Prop() mode!: Mode;
@Prop() modes!: string;
/**
* If the current orientation matches this value, the element will hide.
@ -37,7 +37,7 @@ export class HideWhen implements DisplayWhen {
/**
* If the current platform matches the given value, the element will hide.
* Accepts a comma separated list of platform to match against.
* Accepts a comma separated list of platforms to match against.
*/
@Prop() platform?: string;
@ -55,7 +55,7 @@ export class HideWhen implements DisplayWhen {
@Listen('window:resize')
onResize() {
this.passesTest = updateTestResults(this);
this.passesTest = getTestResult(this);
}
hostData() {