javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-21 04:53:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(picker-column-internal): prevent multiple items from being highlighted at once (#24268)

Browse Source
This commit is contained in:
Amanda Smith
2021-12-01 10:16:58 -06:00
committed by GitHub
parent b0eadfe229
commit c2bef8df14
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/src/components/picker-column-internal/picker-column-internal.tsx
View File

@ -91,7 +91,15 @@ export class PickerColumnInternal implements ComponentInterface {
const ev = entries[0]; const ev = entries[0];
if (ev.isIntersecting) { if (ev.isIntersecting) {
/**
* Because this initial call to scrollActiveItemIntoView has to fire before
* the scroll listener is set up, we need to manage the active class manually.
*/
const oldActive = getElementRoot(this.el).querySelector(`.${PICKER_COL_ACTIVE}`);
oldActive?.classList.remove(PICKER_COL_ACTIVE);
this.scrollActiveItemIntoView(); this.scrollActiveItemIntoView();
this.activeItem?.classList.add(PICKER_COL_ACTIVE);
this.initializeScrollListener(); this.initializeScrollListener();
this.isColumnVisible = true; this.isColumnVisible = true;
} else { } else {
@ -115,13 +123,6 @@ export class PickerColumnInternal implements ComponentInterface {
if (activeEl) { if (activeEl) {
this.centerPickerItemInView(activeEl, false); this.centerPickerItemInView(activeEl, false);
/**
* This is needed because the initial
* scrollActiveItemIntoView call fires before
* the scroll event listener is setup.
*/
activeEl.classList.add(PICKER_COL_ACTIVE);
} }
} }