From c1b61d0fee9d8733ab8f395f070e32683abd8566 Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Sun, 29 Jul 2018 23:10:26 +0200 Subject: [PATCH] chore(): update to ionic-rules/strict --- .../action-sheet-controller.tsx | 1 + .../action-sheet/action-sheet-interface.ts | 1 - .../components/action-sheet/action-sheet.tsx | 81 +++++++++---------- .../alert-controller/alert-controller.tsx | 1 + core/src/components/alert/alert.tsx | 5 +- core/src/components/anchor/anchor.tsx | 4 +- .../animation-controller.tsx | 5 +- .../animation-interface.tsx | 3 - .../animation-controller/animator.tsx | 54 ++++++------- .../animation-controller/transition-end.ts | 7 +- core/src/components/app/app.tsx | 1 + core/src/components/avatar/avatar.tsx | 1 - .../components/back-button/back-button.tsx | 4 +- core/src/components/backdrop/backdrop.tsx | 1 + core/src/components/badge/badge.tsx | 1 + core/src/components/button/button.tsx | 3 +- .../components/card-content/card-content.tsx | 1 + .../components/card-header/card-header.tsx | 1 + .../card-subtitle/card-subtitle.tsx | 1 + core/src/components/card-title/card-title.tsx | 1 + core/src/components/card/card.tsx | 1 + core/src/components/checkbox/checkbox.tsx | 3 +- .../components/chip-button/chip-button.tsx | 2 +- core/src/components/chip-icon/chip-icon.tsx | 1 + core/src/components/chip/chip.tsx | 2 +- core/src/components/col/col.tsx | 1 + core/src/components/content/content.tsx | 3 +- core/src/components/datetime/datetime-util.ts | 22 +---- core/src/components/datetime/datetime.tsx | 8 +- core/src/components/fab-button/fab-button.tsx | 1 + core/src/components/fab-list/fab-list.tsx | 2 - core/src/components/fab/fab.tsx | 1 - core/src/components/footer/footer.tsx | 1 + .../gesture-controller/gesture-controller.tsx | 6 +- .../test/gesture-controller.spec.tsx | 5 -- core/src/components/gesture/gesture.tsx | 2 + core/src/components/grid/grid.tsx | 1 - core/src/components/header/header.tsx | 1 + core/src/components/hide-when/hide-when.tsx | 2 +- core/src/components/img/img.tsx | 3 +- .../infinite-scroll-content.tsx | 1 + .../infinite-scroll/infinite-scroll.tsx | 2 - core/src/components/input/input-base.tsx | 1 + core/src/components/input/input.tsx | 5 +- .../components/item-divider/item-divider.tsx | 1 + core/src/components/item-group/item-group.tsx | 2 +- .../components/item-option/item-option.tsx | 1 + .../components/item-options/item-options.tsx | 1 + .../components/item-sliding/item-sliding.tsx | 12 +-- core/src/components/item/item.tsx | 21 +++-- core/src/components/label/label.tsx | 1 + .../components/list-header/list-header.tsx | 1 + core/src/components/list/list.tsx | 1 + .../loading-controller/loading-controller.tsx | 2 +- .../loading/animations/ios.enter.ts | 1 - .../loading/animations/ios.leave.ts | 2 - core/src/components/loading/loading.tsx | 2 +- .../components/menu-button/menu-button.tsx | 1 + .../menu-controller/animations/overlay.ts | 4 +- .../menu-controller/animations/push.ts | 6 +- .../menu-controller/animations/reveal.ts | 1 + .../menu-controller/menu-controller.ts | 1 + core/src/components/menu/menu.tsx | 21 +++-- .../modal-controller/modal-controller.tsx | 2 +- .../components/modal/animations/ios.enter.ts | 4 - .../components/modal/animations/ios.leave.ts | 1 - core/src/components/modal/modal.tsx | 14 +--- core/src/components/nav-push/nav-push.tsx | 1 + .../components/nav-set-root/nav-set-root.tsx | 1 + core/src/components/nav/nav.tsx | 10 ++- .../nav/test/nav-controller.spec.ts | 25 +----- core/src/components/nav/view-controller.ts | 1 - core/src/components/note/note.tsx | 1 + .../picker-column/picker-column.tsx | 8 +- .../picker-controller/picker-controller.tsx | 2 +- .../components/picker/animations/ios.enter.ts | 1 - .../components/picker/animations/ios.leave.ts | 1 - core/src/components/picker/picker.tsx | 28 +++---- .../popover-controller/popover-controller.tsx | 1 + core/src/components/popover/popover.tsx | 7 +- .../components/radio-group/radio-group.tsx | 2 +- core/src/components/radio/radio.tsx | 3 +- core/src/components/range-knob/range-knob.tsx | 1 + core/src/components/range/range.tsx | 4 +- .../refresher-content/refresher-content.tsx | 2 +- core/src/components/refresher/refresher.tsx | 3 +- .../reorder-group/reorder-group.tsx | 2 +- core/src/components/reorder/reorder.tsx | 1 + .../ripple-effect/ripple-effect.tsx | 5 +- .../components/router-outlet/route-outlet.tsx | 2 +- core/src/components/router/router.tsx | 12 ++- core/src/components/router/test/e2e.spec.tsx | 4 +- .../components/router/test/matching.spec.tsx | 4 - .../components/router/test/parser.spec.tsx | 2 +- core/src/components/router/test/path.spec.tsx | 5 -- core/src/components/router/utils/dom.ts | 3 +- core/src/components/router/utils/interface.ts | 1 - core/src/components/router/utils/matching.ts | 5 -- core/src/components/router/utils/parser.ts | 1 - core/src/components/router/utils/path.ts | 2 +- core/src/components/scroll/scroll.tsx | 3 +- core/src/components/searchbar/searchbar.tsx | 3 +- .../segment-button/segment-button.tsx | 1 + core/src/components/segment/segment.tsx | 2 +- .../select-option/select-option.tsx | 1 - .../select-popover/select-popover.tsx | 8 +- core/src/components/select/select.tsx | 4 +- core/src/components/show-when/show-when.tsx | 5 +- core/src/components/slide/slide.tsx | 1 - core/src/components/slides/slides.tsx | 9 ++- .../src/components/spinner/spinner-configs.ts | 2 - core/src/components/spinner/spinner.tsx | 6 +- core/src/components/split-pane/split-pane.tsx | 15 ++-- core/src/components/tab-button/tab-button.tsx | 2 +- core/src/components/tab/tab.tsx | 1 + core/src/components/tabbar/tabbar.tsx | 31 +++---- core/src/components/tabs/tabs.tsx | 4 +- core/src/components/tap-click/tap-click.tsx | 2 +- core/src/components/text/text.tsx | 2 +- core/src/components/textarea/textarea.tsx | 4 +- core/src/components/thumbnail/thumbnail.tsx | 2 +- core/src/components/title/title.tsx | 1 + .../toast-controller/toast-controller.tsx | 2 +- core/src/components/toast/toast.tsx | 3 +- .../src/components/toggle/test/toggle.spec.ts | 1 + core/src/components/toggle/toggle.tsx | 3 +- core/src/components/toolbar/toolbar.tsx | 1 + .../test/virtual-scroll-utils.spec.ts | 5 -- .../virtual-scroll/virtual-scroll-utils.tsx | 13 ++- .../virtual-scroll/virtual-scroll.tsx | 5 +- core/src/global/ionic-global.ts | 3 +- core/src/utils/animations/ios.transition.ts | 1 - core/src/utils/config.ts | 1 - core/src/utils/framework-delegate.ts | 8 +- core/src/utils/haptic.ts | 24 ++++-- core/src/utils/helpers.ts | 1 + core/src/utils/input-interface.ts | 7 -- core/src/utils/input-shims/hacks/common.ts | 1 - .../src/utils/input-shims/hacks/hide-caret.ts | 9 ++- .../utils/input-shims/hacks/scroll-assist.ts | 2 +- .../utils/input-shims/hacks/scroll-data.ts | 1 - core/src/utils/input-shims/input-shims.ts | 13 ++- core/src/utils/overlays.ts | 10 ++- core/src/utils/show-hide-when-utils.ts | 3 +- core/src/utils/status-tap.ts | 9 +-- core/src/utils/theme.ts | 5 +- core/src/utils/transition.ts | 4 +- core/tslint.json | 9 ++- 148 files changed, 354 insertions(+), 407 deletions(-) diff --git a/core/src/components/action-sheet-controller/action-sheet-controller.tsx b/core/src/components/action-sheet-controller/action-sheet-controller.tsx index 0e2f6de07a..26b5093012 100644 --- a/core/src/components/action-sheet-controller/action-sheet-controller.tsx +++ b/core/src/components/action-sheet-controller/action-sheet-controller.tsx @@ -1,4 +1,5 @@ import { Component, Listen, Method, Prop } from '@stencil/core'; + import { ActionSheetOptions } from '../../interface'; import { OverlayController, createOverlay, dismissOverlay, getTopOverlay, removeLastOverlay } from '../../utils/overlays'; diff --git a/core/src/components/action-sheet/action-sheet-interface.ts b/core/src/components/action-sheet/action-sheet-interface.ts index c059d1bf60..6d4128dddd 100644 --- a/core/src/components/action-sheet/action-sheet-interface.ts +++ b/core/src/components/action-sheet/action-sheet-interface.ts @@ -15,4 +15,3 @@ export interface ActionSheetButton { cssClass?: string | string[]; handler?: () => boolean | void; } - diff --git a/core/src/components/action-sheet/action-sheet.tsx b/core/src/components/action-sheet/action-sheet.tsx index 82f5133488..deb9e3de56 100644 --- a/core/src/components/action-sheet/action-sheet.tsx +++ b/core/src/components/action-sheet/action-sheet.tsx @@ -1,13 +1,14 @@ import { Component, Element, Event, EventEmitter, Listen, Method, Prop } from '@stencil/core'; + import { ActionSheetButton, Animation, AnimationBuilder, Color, Config, CssClassMap, Mode, OverlayEventDetail, OverlayInterface } from '../../interface'; import { BACKDROP, dismiss, eventMethod, isCancel, present } from '../../utils/overlays'; import { createColorClasses, getClassMap } from '../../utils/theme'; + import { iosEnterAnimation } from './animations/ios.enter'; import { iosLeaveAnimation } from './animations/ios.leave'; import { mdEnterAnimation } from './animations/md.enter'; import { mdLeaveAnimation } from './animations/md.leave'; - @Component({ tag: 'ion-action-sheet', styleUrls: { @@ -115,7 +116,6 @@ export class ActionSheet implements OverlayInterface { */ @Event({ eventName: 'ionActionSheetDidDismiss' }) didDismiss!: EventEmitter; - componentDidLoad() { this.ionActionSheetDidLoad.emit(); } @@ -174,7 +174,7 @@ export class ActionSheet implements OverlayInterface { return eventMethod(this.el, 'ionActionSheetWillDismiss', callback); } - protected buttonClick(button: ActionSheetButton) { + private buttonClick(button: ActionSheetButton) { const role = button.role; if (isCancel(role)) { this.dismiss(undefined, role); @@ -190,9 +190,13 @@ export class ActionSheet implements OverlayInterface { if (button && button.handler) { // a handler has been provided, execute it // pass the handler the values from the inputs - if (button.handler() === false) { - // if the return value of the handler is false then do not dismiss - return false; + try { + if (button.handler() === false) { + // if the return value of the handler is false then do not dismiss + return false; + } + } catch (e) { + console.error(e); } } return true; @@ -212,14 +216,11 @@ export class ActionSheet implements OverlayInterface { } render() { + // TODO: move to processedButtons const allButtons = this.buttons.map(b => { - if (typeof b === 'string') { - b = { text: b }; - } - if (!b.cssClass) { - b.cssClass = ''; - } - return b; + return (typeof b === 'string') + ? { text: b } + : b; }); const cancelButton = allButtons.find(b => b.role === 'cancel'); const buttons = allButtons.filter(b => b.role !== 'cancel'); @@ -229,14 +230,12 @@ export class ActionSheet implements OverlayInterface {